Repository navigation
Prevent duplicate mandatory payment rows - #305
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monthly bookkeeping can show the same mandatory payment in both the ledger and its separate section. This successor to #301 keeps bank-only rows in the ledger, removes only mandatory payments represented in the selected month section, and keeps package creation disabled outside a selected month.
Reconciliation and finance share stable bank-row identities and pairing decisions, including manual pairs and rejections. Overlapping statements are deduplicated while distinct repeated payments remain separate; invoice-only candidates do not hide a bank payment. Expense-encoded refunds do not count as paid debits.
Validation so far: focused finance API and summary tests (31 passed), bookkeeping ledger/report tests (25 passed), backend typecheck, and independent review of the preceding commit. A synthetic 1,200-bank-row/1,200-ledger-row pairing benchmark completed in 393 ms, excluding database/network reads. Full exact-head CI and review are required. A separate pre-existing equal-amount cross-tax matching issue is tracked in Hub intake f798503e.