Repository navigation
Match upcoming debits to the correct tax kind - #306
Merged
Merged
Conversation
alexeygrigorev
changed the base branch from
fix/mandatory-payments-successor-1b1d
to
main
November 3, 2026 16:07
Review follow-up on the upcoming-debit tax-kind fix: compare the normalized stored taxType so a case-variant 'Other' still counts as explicitly recorded, and cover income-tax with a valid same-kind payment alongside the existing date/amount rejections.
alexeygrigorev
force-pushed
the
fix/upcoming-tax-kind-f798503e
branch
from
November 3, 2026 16:07
979afc1 to
73360fd
Compare
alexeygrigorev
marked this pull request as ready for review
November 3, 2026 16:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upcoming debit schedules can be marked paid by an equal-value payment of a different tax kind. This change requires compatible tax kinds, uses valid EUR evidence, and leaves competing same-kind matches unresolved.
Depends on #305. Retarget this PR to main after #305 merges. Exact-head independent review and CI are required before merge.
Validation: synthetic finance upcoming, summary and API tests (43 passed); backend typecheck; diff check.