Repository navigation
build(android)!: bump okhttp to 5.5.1 and compileSdk to 37 - #835
Merged
Merged
Conversation
OkHttp 5.5.1 blocks the compromised eMudhra intermediate certificates and matches WordPress-Android. Its okhttp-android artifact requires compileSdk 37, which WordPress-Android already uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dcalhoun
marked this pull request as ready for review
October 26, 2026 14:29
XCFramework BuildThis PR's XCFramework is available for testing. Add the following to your .package(url: "https://github.com/wordpress-mobile/GutenbergKit", branch: "pr-build/835")Built from 8b1bbe3 |
Contributor
|
@dcalhoun Claude found one "must fix":
|
Member
Author
|
@nbradbury I believe the first "must fix" note is not relevant because (A) the PR title including the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Bump
okhttpto5.5.1.Why?
Keep
okhttpupdated with the latest fixes and align with WordPress-Android.How?
Bump
okhttp, and bumpcompileSdkto37as required by theokhttpbump.Testing Instructions
N/A, no user-facing changes.
Accessibility Testing Instructions
N/A, no user-facing changes.
Screenshots or screencast
N/A, no user-facing changes.
AI-generated details
Bumps okhttp
5.3.2→5.5.1andcompileSdk36→37, matching WordPress-Android after wordpress-mobile/WordPress-Android#23447.okhttp-android5.4.0+ requirescompileSdk37, which is what failed build(deps): Bump okhttp from 4.12.0 to 5.5.0 in /android #658. WordPress-Android already uses 37.minCompileSdk=37, sodocs/integration.mdis updated to match.Verified locally:
make test-android-library-unit,make lint-android, and:app:compileDebugKotlin/checkAarMetadatapass.🤖 Generated with Claude Code