Skip to content

build(android)!: bump okhttp to 5.5.1 and compileSdk to 37 - #835

Merged
dcalhoun merged 1 commit into
trunkfrom
build/bump-okhttp-5-5-1
Oct 26, 2026
Merged

dcalhoun merged 1 commit into
trunkfrom
build/bump-okhttp-5-5-1

Conversation

@dcalhoun

@dcalhoun dcalhoun commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

What?

Bump okhttp to 5.5.1.

Why?

Keep okhttp updated with the latest fixes and align with WordPress-Android.

How?

Bump okhttp, and bump compileSdk to 37 as required by the okhttp bump.

Testing Instructions

N/A, no user-facing changes.

Accessibility Testing Instructions

N/A, no user-facing changes.

Screenshots or screencast

N/A, no user-facing changes.


AI-generated details

Bumps okhttp 5.3.2 → 5.5.1 and compileSdk 36 → 37, matching WordPress-Android after wordpress-mobile/WordPress-Android#23447.

  • OkHttp 5.5.1 blocks the 8 compromised eMudhra intermediate certificates on devices without Google Play Services.
  • WordPress-Android already resolves 5.5.1 at runtime, so this aligns the version GBK compiles and tests against with the one that ships.
  • okhttp-android 5.4.0+ requires compileSdk 37, which is what failed build(deps): Bump okhttp from 4.12.0 to 5.5.0 in /android #658. WordPress-Android already uses 37.
  • The published AAR now declares minCompileSdk=37, so docs/integration.md is updated to match.

Verified locally: make test-android-library-unit, make lint-android, and :app:compileDebugKotlin / checkAarMetadata pass.

🤖 Generated with Claude Code

OkHttp 5.5.1 blocks the compromised eMudhra intermediate certificates and matches WordPress-Android. Its okhttp-android artifact requires compileSdk 37, which WordPress-Android already uses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the [Type] Build Tooling Issues or PRs related to build tooling label Oct 26, 2026
@dcalhoun dcalhoun added [Type] Breaking Change For PRs that introduce a change that will break existing functionality Android and removed [Type] Build Tooling Issues or PRs related to build tooling labels Oct 26, 2026
@dcalhoun dcalhoun changed the title build(android): bump okhttp to 5.5.1 and compileSdk to 37 build(android)!: bump okhttp to 5.5.1 and compileSdk to 37 Oct 26, 2026
@dcalhoun
dcalhoun marked this pull request as ready for review October 26, 2026 14:29
@wpmobilebot

Copy link
Copy Markdown

XCFramework Build

This PR's XCFramework is available for testing. Add the following to your Package.swift:

.package(url: "https://github.com/wordpress-mobile/GutenbergKit", branch: "pr-build/835")

Built from 8b1bbe3

@dcalhoun
dcalhoun requested a review from nbradbury October 26, 2026 14:30
@nbradbury

Copy link
Copy Markdown
Contributor

@dcalhoun Claude found one "must fix":

Severity Merge Location Issue Impact
Medium Must fix libs.versions.toml:25 The commit is typed build(android): without the ! breaking-change marker, even though raising the consumer compileSdk floor to 37 is breaking, and #678 used build(android)!: for the bump to 36. The okhttp-android 5.5.1 AAR declares minCompileSdk=37, so any host app on compileSdk 36 now fails checkAarMetadata, and without ! the release gets no [Type] Breaking Change label to warn integrators other than WordPress-Android.
Low Could fix libs.versions.toml:25 Commit 8b1bbe3 ends with a Co-Authored-By: Claude Opus 5.5 trailer, which your global CLAUDE.md forbids. When the PR is merged, the trailer goes into trunk history unless you amend it out or drop it from the squash message (bumped up from Can wait because it breaks an explicit rule of yours).

@dcalhoun

Copy link
Copy Markdown
Member Author

@nbradbury I believe the first "must fix" note is not relevant because (A) the PR title including the ! prefix will become the commit when the squash and merge occurs and (B) the PR has a [Type] Breaking Change label—both ensure the release receives a "breaking change" line. The second note appears to be guidance from your own personal agent configuration. WDYT?

@nbradbury nbradbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :shipit:

@dcalhoun
dcalhoun merged commit da33323 into trunk Oct 26, 2026
33 checks passed
@dcalhoun
dcalhoun deleted the build/bump-okhttp-5-5-1 branch October 26, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Android [Type] Breaking Change For PRs that introduce a change that will break existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants