You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request adds a wix extension update command: it removes all older (but no newer) versions of the extension from the extension cache, then it does the same as wix extension add ... would do.
Is it required to check the version of the found extensions, or could I remove also newer version?
I marked this pull request as "draft" because I want to use the wix extension remove log message that I added in #734. If my suggestion to enhance logging from #734 is accepted, I would also add a similar status message to wix extension add.
Is there anything else that I need to update? Unit tests?
I thought about using ExtensionCacheManager.ListAsync to get a list of all installed versions of an extension, but this method internally loops over a list of cache locations, while AddAsync and RemoveAsync work on a single (the first) cache folder. So I fall back to checking the cache folder content myself.
I extracted the part of ExtensionCacheManager.ListAsync that lists the content of a single extension folder to a new method ListInFolderAsync.
Now, ExtensionCacheManager.UpdateAsync uses this new method to get a list of all versions of the requested extension id and calls ExtensionCacheManager.RemoveAsync.
I have a better feeling now, hope you agree.
The pull requests stays still in "draft" mode, because #734 must be accepted first - as I now use this method, the bug would break everything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves part two of https://github.com/orgs/wixtoolset/discussions/9313: it is not possible to update an extension. So you first have to remove the old version and then add the new version.
This pull request adds a
wix extension updatecommand: it removes all older (but no newer) versions of the extension from the extension cache, then it does the same aswix extension add ...would do.Sample:
Is it required to check the version of the found extensions, or could I remove also newer version?
I marked this pull request as "draft" because I want to use the
wix extension removelog message that I added in #734. If my suggestion to enhance logging from #734 is accepted, I would also add a similar status message towix extension add.Is there anything else that I need to update? Unit tests?