Repository navigation
docs: drop factory from configurable account address examples - #542
Merged
Merged
Conversation
AccountConfig.getAddress now takes only the initial config, so the guide's factory argument broke twoslash with TS2554. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D3nmWfCjwew87TdQBrenPu
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AccountConfig.getAddressnow takes only the initial config (#534), but the configurable accounts guide still passed{ factory }in three examples, sopnpm docs:buildfailed in twoslash with TS2554.site/src/pages/tempo/guides/transaction-envelopes/configurable-accounts.mdxto callAccountConfig.getAddress(initialConfig)and removed the development-factory constants and comments.AGENTS.mdthat said address derivation requires an explicit recovery factory.Verified
pnpm docs:buildcompletes. Docs-only, so no changeset.Generated by Claude Code