Skip to content

fix(build): enable glob patterns in rimraf cleanup scripts - #8446

Open
Tanishdete333 wants to merge 1 commit into
webpack:mainfrom
Tanishdete333:fix/rimraf-glob-cleanup
Open

Tanishdete333 wants to merge 1 commit into
webpack:mainfrom
Tanishdete333:fix/rimraf-glob-cleanup

Conversation

@Tanishdete333

@Tanishdete333 Tanishdete333 commented Oct 17, 2026 •

Copy link
Copy Markdown

Summary

The clean-printable and clean scripts use wildcard patterns with rimraf. On Windows, I reproduced a build failure because glob expansion was not enabled for these commands.

This change adds the --glob option to both scripts so that the wildcard patterns are expanded as intended.

What kind of change does this PR introduce?

Build fix.

Did you add tests for your changes?

No new tests were added. I verified the change by running:

  • npm run clean
  • npm run build
  • Jest: 25 test suites, 105 tests, and 23 snapshots passed.

The full npm test command stopped at the Prettier check. The original, unchanged package.json also failed that check.

Does this PR introduce a breaking change?

No breaking change is intended. The change enables glob expansion in the existing cleanup commands.

If relevant, what needs to be documented once your changes are merged or what have you already documented?

No documentation changes are needed for this build-script fix.

Use of AI

I used ChatGPT as a coding and learning assistant to help investigate the Windows build error, understand rimraf glob behavior, review the proposed changes, and prepare this pull request description.

I ran the commands locally, reviewed the diff, and verified the cleanup script, production build, and Jest test results. I am responsible for reviewing and understanding this contribution and for addressing maintainer feedback.

Summary by CodeRabbit

  • Chores
    • Updated cleanup commands to apply file-pattern matching to generated build and printable files. This keeps cleanup behavior aligned with the configured patterns; the order of the pre-cleanup steps remains unchanged.

@vercel

vercel Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
webpack-js-org Ready Ready Preview Oct 17, 2026 7:41pm UTC

Request Review

@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: Tanishdete333 / name: Tanishdete333 (a410c89)

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 477ffb47-297d-455b-8ae2-3936a13ea277
📥 Commits

Reviewing files that changed from the base of the PR and between be063ea and a410c89.

📒 Files selected for processing: 1
  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The clean-printable and clean scripts now pass --glob to rimraf. The preclean sequence is unchanged.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to a410c

The change is limited to enabling glob expansion in the cleanup scripts, and no concrete merge-blocking risk is evident.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: enabling glob patterns in the rimraf cleanup scripts.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Tanishdete333

Copy link
Copy Markdown
Author

Hi maintainers, Tanish Here! Just following up on this PR when you get a chance. I've tested the cleanup scripts and build locally on Windows, and everything passed. Happy to make any adjustments if needed. Thanks for your time!

This branch was successfully deployed

1 active deployment
Preview — a410c89d Deployed Oct 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant