Repository navigation
fix(build): enable glob patterns in rimraf cleanup scripts - #8446
Tanishdete333 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
|
Hi maintainers, Tanish Here! Just following up on this PR when you get a chance. I've tested the cleanup scripts and build locally on Windows, and everything passed. Happy to make any adjustments if needed. Thanks for your time! |
Summary
The
clean-printableandcleanscripts use wildcard patterns withrimraf. On Windows, I reproduced a build failure because glob expansion was not enabled for these commands.This change adds the
--globoption to both scripts so that the wildcard patterns are expanded as intended.What kind of change does this PR introduce?
Build fix.
Did you add tests for your changes?
No new tests were added. I verified the change by running:
npm run cleannpm run buildThe full
npm testcommand stopped at the Prettier check. The original, unchangedpackage.jsonalso failed that check.Does this PR introduce a breaking change?
No breaking change is intended. The change enables glob expansion in the existing cleanup commands.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No documentation changes are needed for this build-script fix.
Use of AI
I used ChatGPT as a coding and learning assistant to help investigate the Windows build error, understand
rimrafglob behavior, review the proposed changes, and prepare this pull request description.I ran the commands locally, reviewed the diff, and verified the cleanup script, production build, and Jest test results. I am responsible for reviewing and understanding this contribution and for addressing maintainer feedback.
Summary by CodeRabbit