Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Studio admin console does not show which OpenViking version the deployment is running. The server already reports it on
GET /health, and the Studio connection layer already keeps it in the shared health state (useStudioService().version), but no UI consumed it.This PR renders the connected server version in the Studio sidebar footer, so it is visible in the workbench and in the admin console (management mode) alike.
Human Involvement
Related Issue
Fixes #7743
Type of Change
Changes Made
StudioVersion(web-studio/src/features/connection/components/studio-version.tsx), a small component that renders the server version from the shared connection state and renders nothing when the server reports no version.web-studio/src/app/layouts/studio-layout.tsx). The footer is shared by the workbench and the admin console, so both surfaces show the version.appShell.footer.version/appShell.footer.versionTitlemessages inenandzh-CN.No server-side change and no new request: the version comes from the
/healthresponse the Studio already fetches when it connects.Testing
Commands run in
web-studio:Manual check: with the Studio dev server connected to a server whose
/healthreportsversion 0.9.9-mock, the sidebar footer showsOpenViking v0.9.9-mockin the workbench (/home) and in the admin console (/admin/configuration/server).Checklist
Screenshots (if applicable)
The admin console (
/admin/configuration/server) now shows the version in the sidebar footer:Additional Notes
The version badge is hidden when the sidebar is collapsed to icons and when the server reports no version (not connected yet, or offline), so it never shows an empty or stale value.