Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The two search-tag warning tests attach
caplog.handlerdirectly toopenviking.utils.tags. When logging capture is also installed on an ancestor logger, the sameLogRecordreaches the capture handler twice. The existing one-warning assertions then fail even though normalization emitted one warning.Disable propagation with
monkeypatchwhile each test uses its direct capture handler. The fixture restores the original setting after the test; all normalization results, warning counts and warning-content assertions remain in place.Human Involvement
Related Issue
No issue. Reproduced on current
main@f9bf90b3through the existing tests. #6420 proposes removing these warning emissions; this change fixes capture of the current warning behavior independently.Type of Change
Changes Made
logger.propagate = Falseto the two existing tests using themonkeypatchfixture.Testing
On macOS arm64 / Python 3.14.10 with the published OpenViking 0.5.5 native component, synthetic local configuration and no model calls:
All listed patch checks pass. A temporary diagnostic confirmed that each failing base test captured two references to one distinct
LogRecord; with the patch, each captures one record. The diagnostic is not part of the change. Seven existing dependency deprecation warnings remain. The full Python suite was not run.Checklist
Additional Notes
Only the two existing test setups change. There is no runtime or public-interface change.