Repository navigation
feat(installer): install the Antigravity plugin with --harness antigravity - #7715
fancyboi999 wants to merge 6 commits into
Conversation
…adapter Antigravity runs PreInvocation before every model call, so recall runs only on a turn's first call (invocationNum 0), deduplicated per turn. Context returns as an injectSteps system message. Stop carries no text: capture reads the finished steps of transcriptPath after the last captured step, in a detached worker, and commits. Sessions are ag-. Refs volcengine#7709
…input Assistant replies that quote the host's request envelope were reduced to the quoted text, or dropped when the quote was an empty template, and the capture cursor had already moved past them. Unwrap only a USER_INPUT record whose content opens with the envelope; assistant text and the recall prompt only lose injected openviking-context blocks.
|
I found a validation false negative on Using the real
The renderer correctly quotes the path for the shell, but Could validation use the rendered representation or the actual command/runtime contract rather than searching for the raw path? An apostrophe-path control alongside the new install test would protect this boundary. The existing |
|
Thanks, confirmed and fixed in e9189fe.
Verification:
Ran on macOS arm64, local dev source, loopback URL. No real Antigravity/agy session or Windows run for this change. |
|
Confirmed on
AI-only verification on macOS arm64 / Node 26.13.1, temporary homes and loopback configuration. No real Antigravity/agy session, server, release archive, Linux or Windows run. Thanks for adding the regression coverage. |
… wakeups When a background task, subagent reply, timer, or Stop continuation wakes an Antigravity turn, PreInvocation runs again with invocationNum 0, a higher initialNumSteps, and lastUserInput still holding the earlier prompt. Keying prompt_id by initialNumSteps bypassed promptEventId deduplication and re-injected the cached recallBlock into the trajectory on every wakeup. Resolve the active user turn from transcriptPath instead: skip recall when a MODEL step has already run since the latest USER_EXPLICIT USER_INPUT step, and key prompt_id by that user step (step_index + 1) so each user turn injects once while still recalling on genuine repeated prompts.
e9189fe to
d3b1307
Compare
…l steps Backgrounded run_command steps (MODEL/GENERIC with status RUNNING) and failed or invalid tool steps (ERROR, INVALID) stay non-DONE permanently in Antigravity transcripts. Breaking on every non-DONE step froze lastStep before all subsequent turns in that conversation. Advance lastStep past non-captured step types regardless of status. On captured turn records (USER_EXPLICIT USER_INPUT and PLANNER_RESPONSE), hold the cursor only while the step is in progress (PENDING, QUEUED, WAITING, RUNNING, GENERATING), and skip terminal non-DONE records (CANCELED, ERROR, INVALID, ...) without blocking later turns.
…avity Antigravity (the desktop app and agy) loads plugins from directories under ~/.gemini/config/plugins, each a plugin.json and a hooks.json keyed by hook name. The installer now assembles the runtime under ~/.openviking/agent-integrations/antigravity and writes the plugin directory whole, with commands rendered to the installed runtime and the integration env prefix. A directory of that name the installer did not write is left in place, on install and on uninstall. Antigravity is detected by agy on PATH or its configuration directory, offered in the selection list, validated with a smoke run, and kept in the shared-runtime cleanup guards so removing another host does not remove the runtime it uses. MCP stays manual: Antigravity keeps it in a shared mcp_config.json with its own schema.
… command The renderer shell-quotes the runtime path, so a path with an apostrophe appears in hooks.json as '"'"' rather than verbatim, and the grep for the raw path reported a complete install as incomplete. Validation now reads the SessionStart command from hooks.json and runs it through sh with memory disabled, the way Antigravity runs it. A test installs under a home path containing an apostrophe.
d3b1307 to
42038c7
Compare
Description
Stacked on #7710: this branch contains its four commits, and only the last two commits (
feat(installer): …andfix(installer): …) are new here. I will rebase it ontomainafter #7710 merges.gh stackcannot link the two on GitHub because a PR from a fork cannot use another fork branch as its base.#7710 adds the Antigravity host adapter but leaves installation to manual steps. This PR adds
--harness antigravitytoinstall.sh, so the Antigravity desktop app and theagyCLI install like the other config-driven hosts:curl -fsSL https://openviking.ai/install | bash -s -- --yes --harness antigravityAntigravity loads plugins from directories,
~/.gemini/config/plugins/<name>/{plugin.json,hooks.json}, and itshooks.jsonkeys each entry by hook name. That shape is different from the{ "hooks": { … } }fileshost-json-config.mjsmerges. Antigravity also owns the whole plugin directory, so nothing has to be merged. The installer therefore:~/.openviking/agent-integrations/antigravity, the same way the other hosts do;~/.gemini/config/plugins/openviking-memoryas a whole. Each command points at the installedscripts/hook.mjswith the usualOPENVIKING_INTEGRATION_IDenv prefix and a# openviking-memorytag;hooks.jsonpasses the existingownsHook()check. A plugin written by the manual steps from feat(agent-hook-plugin): add Antigravity (app and agy CLI) as a host adapter #7710 passes the check and is replaced.Human Involvement
Related Issue
Part of #7709
Type of Change
Changes Made
install.sh:--harness antigravityand an entry in the selection list.agyon PATH, or~/.gemini/config, which both the app andagycreate. The check does not look in/Applications, because that path is machine-wide and would leak into the TUI tests' temporary homes on a Mac that has the app.install_antigravity, uninstall and validation. Validation checks the files, the rendered command,node --check, and a smoke run with memory disabled.antigravity, so removing Cursor or a legacy TRAE CLI install does not delete the runtime that Antigravity still runs from.install.sh, not inmemory-plugin-shared/lib/. A change tolib/counts as a change to every plugin incheck-plugin-version-bumps.sh.install-agent-hooks.test.mjs, two new tests:sh -cas Antigravity does, check that removing Cursor keeps the shared runtime, and uninstall.agent-hook-pluginfrom 0.5.32 to 0.5.33, with the host manifests, because its README changed.Intentionally out of scope:
~/.gemini/config/mcp_config.json, with its own schema (serverUrlfor HTTP servers). Users often have anopenvikingentry there already, so the docs keep MCP as a manual step.HARNESS_KEYSinconfig-schema.mjs. Adding the key is only needed for per-harness overrides inovcli.conf. Throughsync.mjsit would also touch the Claude Code and Codex plugins, so it can be a separate change.Testing
All commands ran on macOS with Node 26.
node --testonexamples/*/tests,memory-plugin-shared/*.test.mjsandlib/install/*.test.mjspi-coding-agent-extension(its dependencies are not installed in this checkout). 1 is the pre-existinginstall-tui"listed again just before the onboarding link" failure noted in #7710.install-tui.test.mjs/Applications/Antigravity.appfailed 5 detection tests on this Mac, which led to the detection rule above.antigravityshared-runtime guard, makes one of the new tests fail.check-plugin-version-bumps.shagainstorigin/mainand against the #7710 branchsync.mjs, thengit statusbash -n install.sh,check-docs-consistency.mjsReal host check. I installed with
install.sh --source dev --harness antigravityinto the real home.OPENVIKING_CLI_CONFIG_FILEpointed at a temporary file, so the existingovcli.confstayed unchanged. Then a newagy1.5.9 print-mode session answered from recalled memory without calling tools. Antigravity ran the env-prefixed commands through its shell. The hook state recordedlastStep, and the server sessionag-<id>reportscommit_count: 1, against OpenViking server 0.5.0.The Antigravity desktop app was then checked with the same installer-written plugin. A new app conversation showed the "Hook Json SessionStart" and "Hook Json PreInvocation" steps. Its hook state recorded the recall and
lastStep, and the server sessionag-<id>reportscommit_count: 1.Not covered: Linux and Windows.