Repository navigation
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 2
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
|
madolson
left a comment
There was a problem hiding this comment.
Overall I think most of the structure is OK. It would be nice to add some more narrative structure instead of just a list of features. I would rather talk about fewer features but explain in more detail why they are useful. Lots of aside comments like, "Along with info fields" which I don't think are necessary. When talking about performance, we should include headline numbers when they're relevant.
stockholmux
left a comment
There was a problem hiding this comment.
I'll withhold specific comments until the next revision.
1.) The blog is comprehensive, but I think that might be a weakness. It reads like expanded release notes, which is probably not the goal.
2.) It needs to be shorter. We don't need to give every detail. Let's look at the banner features/themes (what we wrote blogs about) and give a 1-3 paragraph description. Focus on why this is important and less of what the feature does.
3.) Anything that falls below the threshold of banner feature goes into a single heading - group these if possible.
4.) The intro needs to underline why this release is important.
5.) The confusion needs to give some more interesting CTAs. What's your favourite - post about that? Can you add these features change another open source project - make the changes, etc.
|
@stockholmux thank you for the review! I went into this with a technical mindset and went gung-ho on the details. I took your points and rethought how this release brings value to our readers so I restructured the content:
I was thinking what to do with the "smaller" features, so I pulled them into the Also in this release subtopic, I think it saves the reader time to quickly skim over since they're already reading the blog but I can delete it if it feels like too much padding. I do have a question though, is it ok since we have deep-dive posts for the banner features, to add the links to them once they're merged (and this one releases)? |
Covers highlights from the 9.2 release including: Persistence and replication: forkless snapshots and full syncs, LZ4/Zstandard streaming compression, replication throttling Security: ACL roles with CLI examples, ACL DIGEST, secondary TLS certificate, OpenSSL-sourced randomness Availability under load: priority for system-critical events, reserved connections for administrators, cluster failover controls Performance: B+ tree sorted sets, batched lookups and prefetching, faster replication and cluster bus Efficiency: listpack for hashes with field expiration, shared client objects, script cache limit Observability: server-side hot key detection, transactions in the slow log, replication and cluster link metrics New data type and commands: Path Hash with CLI examples, INCREX, DELEX, conditional EXEC, XACKDEL/XDELEX Tooling: valkey-benchmark datasets and larger keyspaces, valkey-cli environment variables Before you upgrade: behavior changes to check Closes valkey-io#676 Signed-off-by: Dragos Andriciuc <andriciucdragos@protonmail.com>
Fix featured image path and fix command links that have no docs yet. Signed-off-by: Dragos Andriciuc <andriciucdragos@protonmail.com>
Applied all feedback from madolson, including rewrites, deletion of extra bug type content, expanded how it works for multiple features, updated hero image and applied the CTA fix. Signed-off-by: Dragos Andriciuc <andriciucdragos@protonmail.com>
Made the following changes: - rewrite the intro around getting more out of existing hardware, - turn banner features into short, benefit-focused sections, - group the remaining changes under "Also in this release" (could remove...) - Replace the closing with updated CTAs Signed-off-by: Dragos Andriciuc <andriciucdragos@protonmail.com>
- I didn't like the intro so I changed it again - clarify how XACKDEL and XDELEX delete stream messages in ACKED mode. Signed-off-by: Dragos Andriciuc <andriciucdragos@protonmail.com>
5b83c5f to
f89c1b5
Compare
|
Rebased. |
[Low impact] The change reaches readers of the Valkey blog, not running Valkey deployments. Hold merging until the post has Findings
|
Description
Covers highlights from the 9.2 release including:
Issues Resolved
Closes #676.
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.