Repository navigation
compress: separate dictionary IDs from error returns - #1
Open
trestoncuzzort wants to merge 4 commits into
Open
trestoncuzzort wants to merge 4 commits into
trestoncuzzort wants to merge 4 commits into
Conversation
ZSTD_loadZstdDictionary() and ZSTD_compress_insertDictionary() returned both dictionary IDs and errors through size_t. On 32-bit builds, valid private dictionary IDs near UINT32_MAX overlap the encoded error range and are rejected by their callers. Return a status and write the ID through an output parameter instead. Raw or absent dictionaries still produce ID zero, and failed loads still return their error before the caller stores the ID. Add round trips and frame-ID checks for low and high IDs through direct dictionaries, prepared CDicts, and CCtx-loaded dictionaries.
added 3 commits
October 25, 2026 19:49
Pin jobs requiring gold or qemu-user-static to Ubuntu 24.04 and the MinGW Clang job to 21.1.8. Preserve all test targets and flags. Compare Clang 18 static analysis of the upstream base and exact source patch. Fork validation only; not part of the upstream change.
Use the distribution multilib compiler package instead of a hardcoded GCC 13 support library. The latest runner uses GCC 15 and cannot link the 64-bit target with the previous dependency. Fork validation only.
Pin the two legacy environment checks without changing their commands or size limits. Keep the already collected exact-base/exact-fix analyzer comparison manual so infrastructure-only changes do not repeat it. Both analyzer failures remain documented.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validates the fix for facebook/zstd#4580. High dictionary IDs allowed for private use overlap encoded
size_terrors on 32-bit builds. Internal loaders now return status and write the ID separately.The source patch is
ac6e2475a827ad0e373bd3844f0e2df01c781b5donfix-high-dict-id. This validation branch adds workflow changes only; all non-workflow files match the source patch.Validation:
93d04fe, but only 101 validate the patch. The three OSS-Fuzz jobs failed to fetch this fork's PR from upstream and continued on upstream code. Their green results are excluded. Exact-source replacement run 40256366732 has now passed. All 21 targets completed under each of address, undefined and memory sanitizers with the 600-second budget per job. Source commit and four hashes match before/after building; logs confirm the checkout was copied into the builder. Changed-file filtering failed, so all targets ran. Five public corpus downloads returned 403; those targets still completed, with warnings retained.make staticAnalyzeis not clean: Clang 23 gives the same 15 diagnostic/source signatures on base and fix; a separate Clang 18 comparison gives the same nine. Both versions fail on both revisions. Those results remain retained.Upstream draft: facebook#4864. The fork workflow changes are excluded from that source-only PR. Meta requires the contributor to sign its CLA before review and merge.
OpenAI Codex (GPT-6) assisted with investigation, implementation and tests. dawnr checked a mathematical status-encoding model; it does not prove the C implementation.