Repository navigation
share-session says what to type, folder numbers included - #847
Merged
Merged
Conversation
The send question was only '→ Send it? [y/N]', so a teammate didn't know folders could be left out. One line now says what each answer does, then a bare → prompt; folders can be left out more than once.
🌱 graft blast radiusNothing outside this diff depends on it. 2 areas changed; no indexed dependents at depth 2. Test signal per changed area — 1 ✓ · 1 ✗Reached = a node under a test path has a resolved edge into the changed symbol. It undercounts anything called indirectly — through a CLI, a spawned process or a dynamic import — so read a low ratio as “look here”, never as a coverage gate.
Open the interactive graph → — click an area to see the code that changed, and the line that reaches it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A teammate ran
trail share-sessionon 0.30.4, saw his folders listed, and asked if there was a way to leave some out: the question after the preview was only→ Send it? [y/N]. Typing folder numbers there still worked, but nothing said so; #840 took the hint out of the question so the yes/no wouldn't be buried.The question is now one line that says what to type and what each answer does, then a bare
→prompt:Type y to send it, or n to send nothing.Enter still sends nothing.… or more folder numbers to leave out (like 3)). Before, it allowed one round and then only yes or no.parseLeaveOut).SEND_ASKandSEND_REST_ASKare replaced bysendAsk(manifest, rest).Moves: none of the current project's metrics. It should raise how many share-session previews end in a send rather than a no (
share_bundlewith outcomesentorpartial). A person who wants to hold a folder back can now do that instead of declining the whole share.Tests:
test/share-bundle.test.tscovers the line for one, two and three folders, the "rest" wording, and that a left-out folder can't be picked again. The share suites pass (52 of 52). Also run end to end in a pseudo-terminal, astrail share-session --onceagainst a local stand-in for Trail with three folders: typing2left that folder out and showed the preview again, andysent the setup and the other two sessions, never the left-out one.trail checkflags the 16 Nov learning that ruled out "or type folder numbers to leave out" in the question, because it buried the yes/no. This PR replaces that learning (l-9cb501d1): the yes/no still reads first, and the line says what to type rather than asking two questions at once.🤖 Generated with Claude Code