Repository navigation
Document and hint qualified entity references - #59
Open
StevenACoffman wants to merge 3 commits into
Open
StevenACoffman wants to merge 3 commits into
StevenACoffman wants to merge 3 commits into
Conversation
The warning for an import nothing references still said to reference one of its enums in an attribute type. Since ADR-0018, an imported entity can also be referenced as scope.Entity in a relationship or subtypeOf, so the hint now offers both. The test asserts the full hint rather than only "is never referenced". Signed-off-by: Steve Coffman <steve@khanacademy.org>
domain-model-author said relationship.entity and subtypeOf cannot be qualified, and domain-model-lint called that a structural error. Both predate ADR-0018 (7aa1f40), which made scope.Entity valid there. Say what is supported, note that checks stop at the import boundary, and list the semantic error for an unresolved scope.Entity. Signed-off-by: Steve Coffman <steve@khanacademy.org>
"The two nothing-references-it checks" followed a list of three. The linter relaxes the unused glossary term and unused enum checks for a shared model, but still warns on an unused import. Signed-off-by: Steve Coffman <steve@khanacademy.org>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for making cool stuff. I noticed a few skills were stale, and some of the lint messages, so I spruced them up a bit.
ADR-0018 (7aa1f40) made
scope.Entityvalid inrelationship.entityandsubtypeOf, but some text still described the older, enum-only behavior:domain-model-authorsaid entity references can't be qualified, anddomain-model-lintcalled them a structural error. Both now describe what's supported, note that checks stop at the import boundary, and list the semantic error for an unresolvedscope.Entity.shared: truerelaxes (unused glossary term, unused enum) and says the unused-import check still applies, which is what the code does.task checksteps all pass locally (vet, staticcheck, golangci-lint v2.12.2, tests, model lint, render-check, plugin validate).