Repository navigation
test: widen the real-time bounds of the conformance helpers - #7
Merged
Merged
Conversation
The iOS simulator job failed twice on "invariant 6: a request of an ended session that never answers cannot block the next session" (.signOutThenSignIn): finishes(next) gave up after 2 s of real time. The log shows the next session's refresh rotating its token right after the failure, so the manager was correct and the bound was too short. On the CI simulator the parallel run is starved: trivial tests report 4 to 10 s. finishes, waitUntil and the sleeper wait in the hung-policy test check something that either happens soon or stays false until the test intervenes, so a long bound only delays a real failure. Raise them to 30 s, well inside the suites' one-minute time limit.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flaky
iosCI job.The iOS simulator run failed twice on "invariant 6: a request of an ended session that never answers cannot block the next session" (
.signOutThenSignIn):finishes(next)gave up after 2 s of real time, while the log shows the next session's refresh rotating its token right after. The simulator's parallel run is starved (trivial tests report 4–10 s), so the bound was too tight, not the manager.Included:
finishes: 2 s → 30 s, with a comment on why the bound is generouswaitUntil: 5 s → 30 sEach checks something that happens soon or stays false until the test intervenes, so a long bound only delays a real failure. All stay inside the suites' one-minute time limit.
Test-only change; no public API or behaviour change.