Repository navigation
Release 1.0.1: keep warnings-as-errors out of the manifest - #10
Conversation
Xcode builds a remote package with -suppress-warnings. Combined with
.treatAllWarnings(as: .error) from Package.swift it refuses to build
("conflicting options '-warnings-as-errors' and
'-suppress-warnings'"), so an app could not depend on PassportKit
through Xcode 26.4. The make targets pass the flag instead, which
keeps warnings as errors for this repository's own builds and CI.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49d0d6d1ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| swift build --build-tests $(WARNINGS_AS_ERRORS) | ||
|
|
||
| test: | ||
| swift test --parallel | ||
| swift test --parallel $(WARNINGS_AS_ERRORS) |
There was a problem hiding this comment.
When a warning occurs only in iOS-specific code, the added flags do not catch it: the iOS job in .github/workflows/ci.yml runs make test-ios, which delegates to scripts/test-ios.sh, and its xcodebuild test invocation supplies no warnings-as-errors setting. Removing the manifest setting therefore makes such warnings non-fatal even though they were fatal before this change; pass the equivalent setting through the local iOS test build as well.
Useful? React with 👍 / 👎.
Xcode builds a remote package with
-suppress-warnings. With.treatAllWarnings(as: .error)inPackage.swiftit refuses both flags ("conflicting options '-warnings-as-errors' and '-suppress-warnings'"), so an app could not depend on PassportKit through Xcode 26.4. The flag now lives in themake build/make testtargets, so this repository's own builds and CI keep treating warnings as errors;docs/spec.md§2 and the changelog say so.make checkpasses, and a deliberately introduced warning still failsmake build.