Repository navigation
Conversation
When enabled-plugins or disabled-plugins changed outside the Plugins page, enable_configured_plugins() skipped a plugin whose module was already loaded, so a plugin turned off and on again that way stayed enabled with no extension and its settings page showed No settings available until the shell restarted. Create the missing extension in that case. Assisted-by: Claude Code:claude-opus-5-5 AI-Scope: added the enabled-but-no-extension branch in enable_configured_plugins().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enabled-plugins or disabled-plugins changes outside the Plugins page (for example a plugin turned off and back on with gsettings), enable_configured_plugins() finds the module already loaded and skips it. The plugin stays enabled without an extension and its page shows "No settings available" until the shell restarts. Create the missing extension in that case. load_extension() already returns early when the extension exists.
@mirkobrombin for review when you have a moment.
AI assistance: disclosed