Repository navigation
Conversation
The overview is a full-output layer surface with exclusive zone -1, and the dock stays above it on the overlay layer, shown while the overview is open even in autohide and intellihide modes. The grid viewport ran under the dock and the dock covered the bottom row of icons; a side dock was only accounted for when autohide was off. Add Dock.shown_extent(), the distance the shown dock reaches in from its edge (the exclusive zone it claims when always visible plus its layer margin), and inset the overview content stack by it on the dock edge. The grid viewport height hint and the column count use the remaining area. Search results get the same inset. Assisted-by: Claude Code:claude-opus-5-5 AI-Scope: Located the overview/dock layering cause and wrote the dock inset change; reviewed and tested on hardware by the author.
Contributor
Author
|
@mirkobrombin for review when you have a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overview is a full-output layer surface with exclusive zone -1, and the dock stays above it while the overview is open, also with autohide and intellihide. The grid used the full output height, so the dock covered the bottom row of app icons. A side dock was only accounted for when autohide was off.
This adds
Dock.shown_extent()(the exclusive zone the dock claims when always visible, plus its layer margin) and insets the overview content by it on the dock's edge. The grid's viewport hint and column count use the area that is left, and search results get the same inset.Before: with the default bottom dock the last row of icons sat under the dock at every scale we tried (1920x1080 at 1x, 3840x2160 at 1.75x and 2x, 3072x1920 at 2x).
After: the last row ends above the dock and the grid scrolls as before, on the same outputs, on amd64 and arm64.
Not changed: overviews on secondary monitors (they have no dock).
Build and tests on Debian forky:
ninjabuilds,meson test82 of 84 pass, the same as main (parental-helperandcrash-handlerfail identically on main in a container).AI assistance: disclosed