Repository navigation
feat(wallpaper): add smart rotation selection - #34
Merged
mirkobrombin merged 1 commit intoOct 14, 2026
Merged
mirkobrombin merged 1 commit into
mirkobrombin merged 1 commit into
Conversation
perlowja
force-pushed
the
feat/wallpaper-smart-rotation-phase3-pr
branch
from
September 29, 2026 22:15
015b9c9 to
137443b
Compare
Add minimum dimensions, aspect preference, favorites weighting, and an immediate-next action with deterministic tests. Assisted-by: Claude Code:claude-sonnet-5 Assisted-by: Codex:gpt-5.6-sol AI-Scope: Rebased Phase 3, retained generic Singularity paths, resolved rotator overlaps, completed schema coverage, and fixed focused test dependencies.
mirkobrombin
force-pushed
the
feat/wallpaper-smart-rotation-phase3-pr
branch
from
October 14, 2026 10:57
137443b to
211eafe
Compare
Member
|
Aligned and merging. This branch also carried #30, #32 and #33, so I replayed only the rotation commit on main and resolved the meson and test schema conflicts. The selection fallbacks were called test_, renamed them to default_ since they're live defaults, not test code. Rotator, gallery and OCS tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #32. This branch is based on the current Phase 1 PR head because favorites weighting uses
WallpaperFavorites; it must be rebased ontomainafter #32 merges.The shipped GSettings contract is in singularityos-lab/singularity-desktop#266; this PR must not merge before that schema change ships.
Adds minimum image dimensions, display-aspect preference, threefold favorites weighting, and an immediate Next Wallpaper action. All paths use the existing generic Singularity conventions:
~/.config/singularity/wallpaper-rotationandsingularity/wallpaper-collections.Verification:
wallpaper-rotator-test: 19/19 passed, including deterministic dimension, fallback, aspect, exact favorites-weighting, and immediate-next casesAI assistance: disclosed