Skip to content

Add advisory for auth-framework: Revoking an OAuth2 refresh token does not prevent it from minting new access tokens #3399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ciresnave-bot wants to merge 2 commits into from
Closed

Add advisory for auth-framework: Revoking an OAuth2 refresh token does not prevent it from minting new access tokens #3399

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dcc3a0
Add advisory for auth-framework: GHSA-rf2h-7m78-hhjm
ciresnave-bot Oct 18, 2026
642724f
Update for auth-framework 0.4.30 (0.4.x placeholder handlers now answ…
ciresnave-bot Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions crates/auth-framework/RUSTSEC-0000-0000.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "auth-framework"
date = "2026-10-04"
categories = ["privilege-escalation"]
keywords = ["oauth2", "token-revocation", "refresh-token", "api-server"]
aliases = ["GHSA-rf2h-7m78-hhjm"]

[versions]
patched = [">= 0.4.30, < 0.5.0-rc1", ">= 0.5.0-rc26, < 0.6.0-rc1", ">= 0.6.0-rc41"]
unaffected = ["< 0.4.0"]
```

# Revoking an OAuth2 refresh token does not prevent it from minting new access tokens

Revoking an OAuth2 refresh token through `POST /oauth/revoke` (feature `api-server`) has no effect on that token's ability to mint new access tokens, so a compromised or intentionally revoked refresh token keeps working.

On the 0.5 line the revoke handler stores a revocation marker but never deletes the refresh-token record, and `handle_refresh_token_grant` never checks the marker. On 0.4.x the handlers `revoke_token` and `handle_refresh_token_grant` in `src/api/oauth.rs` are unimplemented stubs (explicit `// In a real implementation` comments), so revocation is a no-op and the refresh grant does not validate the token, giving the same user-visible defect.

Affected: every published 0.4.x version (0.4.0 up to 0.4.29) and 0.5.0-rc1 up to 0.5.0-rc25. Fixed in 0.5.0-rc26 (per the GHSA patched version); 0.4.30 is not affected: in its published source the OAuth2 handlers of `api::oauth` (including `revoke_token`) answer HTTP 501 Not Implemented and the refresh grant is gone, so no 0.4.x refresh token can mint access tokens there; the GHSA itself records no patched 0.4.x version. No workaround short of a code change is known.
Loading