Skip to content

Add 24 advisories: auth-framework (18), role-system (4), commy (2), one commit each - #3386

Open
ciresnave-bot wants to merge 24 commits into
rustsec:mainfrom
ciresnave-bot:auth-framework-fixed-keys
Open

ciresnave-bot wants to merge 24 commits into
rustsec:mainfrom
ciresnave-bot:auth-framework-fixed-keys

Conversation

@ciresnave-bot

@ciresnave-bot ciresnave-bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Affected crate(s)

  • auth-framework (about 2,000 recent downloads per crates.io): 18 advisories
  • role-system (about 4,300 recent downloads per crates.io): 2 advisories

Links to upstream issue(s) or PR(s)

I am the maintainer of both crates (CireSnave, https://github.com/ciresnave). Each advisory is already published as a GitHub security advisory upstream, and the fix is released to crates.io (the older ones are a backfill of earlier fixed defects):

Severity

Authorization and authentication flaws: fixed signing keys that let anyone forge tokens or introspection responses (auth-framework), MFA and OAuth2 bypasses, a predictable fallback TOTP secret, and in role-system a permission cache that answers one resource type from another's decision and instance-scoped permissions that grant every instance. Details and per-version ranges are in each advisory.

Checklist

  • Advisory filename(s) starts with RUSTSEC-0000-0000 as the ID (.N suffixes so the files coexist, as suggested)
  • date field is set to the public disclosure date (the GHSA publication date)
  • Contains a concise and descriptive title after advisory metadata
  • Asked maintainer(s) if publishing an advisory is appropriate (I am the maintainer)

patched/unaffected were checked against every published version of each crate (0 mismatches against the GHSA ranges); the files parse with rustsec 0.33 and lint with rustsec-admin 0.8.9.

🤖 Generated with Claude Code

@djc

djc commented Oct 18, 2026

Copy link
Copy Markdown
Member

Use the pull request template, and make one PR with a commit per advisory.

@ciresnave-bot
ciresnave-bot force-pushed the auth-framework-fixed-keys branch from f99b248 to 999ec89 Compare October 18, 2026 07:40
@ciresnave-bot ciresnave-bot changed the title Add advisory for auth-framework: fixed signing keys in JARM, JWT introspection and default SAML Add 20 advisories: auth-framework (18) and role-system (2), one commit each Oct 18, 2026
This was referenced Oct 18, 2026
@ciresnave-bot ciresnave-bot reopened this Oct 18, 2026
@ciresnave-bot
ciresnave-bot force-pushed the auth-framework-fixed-keys branch from f3e5b38 to 28106fb Compare October 18, 2026 07:53
@ciresnave-bot ciresnave-bot changed the title Add 20 advisories: auth-framework (18) and role-system (2), one commit each Add advisories for auth-framework and role-system (one commit each) Oct 18, 2026
@ciresnave-bot

Copy link
Copy Markdown
Author

Thanks, and sorry about the first version. This is now one PR with one commit per advisory, using the template.

A question about volume: I have 18 further advisories for auth-framework (earlier fixed defects) and one more for role-system, all already fixed and published. The lint requires the file to be named exactly RUSTSEC-0000-0000.md (I tried suffixed names in one PR and it rejected them), so only one advisory per crate fits in a PR. Would you prefer I open the remaining ones as follow-up PRs one at a time after this merges, or in some other layout? I will wait for your answer before sending any more.

@djc

djc commented Oct 18, 2026

Copy link
Copy Markdown
Member

The name needs to start with RUSTSEC-0000-0000 but otherwise you can drop a .0 etc in there.

@ciresnave-bot
ciresnave-bot force-pushed the auth-framework-fixed-keys branch from 28106fb to f6991b5 Compare October 18, 2026 08:40
@ciresnave-bot ciresnave-bot changed the title Add advisories for auth-framework and role-system (one commit each) Add 20 advisories: auth-framework (18) and role-system (2), one commit each Oct 18, 2026
@ciresnave-bot

Copy link
Copy Markdown
Author

Thanks, that worked: files are now RUSTSEC-0000-0000.N.md (one commit each, 18 for auth-framework and 2 for role-system) and the lint passes.

@ciresnave-bot ciresnave-bot changed the title Add 20 advisories: auth-framework (18) and role-system (2), one commit each Add 22 advisories: auth-framework (18) and role-system (4), one commit each Oct 18, 2026
@ciresnave-bot ciresnave-bot changed the title Add 22 advisories: auth-framework (18) and role-system (4), one commit each Add 24 advisories: auth-framework (18), role-system (4), commy (2), one commit each Oct 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants