Repository navigation
rerun cpp-overload-test build script when src/ changes - #63
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: Ikeh Chukwuka <mrikehchukwuka@gmail.com>
0xull
force-pushed
the
build-rs-rerun-if-changed
branch
from
October 26, 2026 05:43
85794b2 to
9ca886f
Compare
teor2345
approved these changes
Oct 27, 2026
teor2345
left a comment
teor2345
left a comment
Collaborator
There was a problem hiding this comment.
This looks good enough to go, thank you!
| cargo test --all-features --package cpp-overload-test --lib | ||
| cargo test --doc --all-features --package cpp-overload-test | ||
| cargo fmt --package cpp-overload-test -- --check | ||
| - name: Check changed cpp! code is rebuilt |
Collaborator
There was a problem hiding this comment.
Normally I would split this out into a separate job, but we're getting a lot of jobs now, so I don't think it matters that much.
If it turns out this job is always the slowest, or it fails, we can change it later.
| // `cc` prints `rerun-if-env-changed` lines, which turns off Cargo's default rescan of the | ||
| // package, so instruct Cargo to rerun this script whenever `src/` changes and pick up | ||
| // `cpp!` updates. | ||
| println!("cargo::rerun-if-changed=src"); |
Collaborator
There was a problem hiding this comment.
It would be great to upstream this fix to cpp. But this is an optional change, please prioritise completing your overloading wrapper PR during the Outreachy application period.
If you do have time to do both, feel free to include it in your Outreachy application.
teor2345
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #61
adds
cargo::rerun-if-changed=srctocpp-overload-test/build.rs.once a build script prints any
rerun-ifline, cargo stops rescanning the package (cargo docs). so editing acpp!block never reran the script, and the build failed with "This cpp! macro is not found in the library's rust-cpp metadata" untilbuild.rswas touched.after
touch cpp-overload-test/src/stdcpp/forward_list.rsandcargo build -v:before:
after:
edit:
the pr adds a CI test in the
cpp-overload-test-okjob. it tests thecpp!code insrc/rerun_check.rs, then copiesrerun-check/rerun_check.rsover it to change the existingcpp!block and add a new one. after that it tests again withoutcargo clean. with thererun-if-changedline removed, the second test fails with the metadata error. also, i updated the "Testing Quirks" section inREADME.md.