Repository navigation
Add std::chrono::time_point constructor overloads and tests - #50
yalagadapavankumar wants to merge 7 commits into
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This is now fixed, and if people accidentally introduce themselves somewhere else, someone from the community will move their post to the right channel. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
teor2345
left a comment
There was a problem hiding this comment.
Almost there, just need to tweak it to match the C++ overloads a bit more closely.
teor2345
left a comment
There was a problem hiding this comment.
Thanks, this looks good, let's move on to stage 2 of this task, using the instructions in the PR description.
Please create a new file with examples of failing overloads, the instructions for creating the stderr file are here:
overloading-macros/.github/workflows/check.yml
Lines 207 to 208 in 3e009c3
| //! ### Limitations | ||
| //! | ||
| //! C++ time points use clock and duration types. | ||
| //! This test uses fixed types instead of supporting all possible types. |
There was a problem hiding this comment.
This isn't a blocker for stage 2, but in your next update, please move this comment next to the declarations of those fixed types
Add C++
std::chrono::time_pointconstructors in Rust usingoverload!macro.Limitationsdoc sectionErgonomicsdoc sectionIncompatibilitiesdoc sectionWorkaroundsdoc sectionInexpressible Overloadsdoc section