Repository navigation
chore: upgrade to Expo SDK 58 - #172
Open
fernandatoledo wants to merge 7 commits into
Open
fernandatoledo wants to merge 7 commits into
fernandatoledo wants to merge 7 commits into
Conversation
- Bump Expo to SDK 58 (RN 0.88, React 19.3, TypeScript 6) and align native deps - Raise iOS deployment target to 16.4 (required by SDK 58) - Bump react-native-mmkv to 4.3 and nitro-modules to 0.37 (old ones crash on RN 0.88) - Replace react-native-edge-to-edge with expo-status-bar (edge-to-edge is built in) - Move @react-navigation imports to expo-router entry points - Add explicit redirectTo on Stack.Protected guards (SDK 58 changed the fallback) - Adopt iOS 26 transparent headers: header screens use ScrollView with content insets - Fix RN 0.88 strict types for refs and styles - Update Jest setup for Jest 30, Reanimated 4.7 and Worklets 0.13
- Use Reanimated's official Jest resolver instead of mocking private paths - Restore the progress bar test that checks setProgress updates the width - Extract the guard fallback route and cover every auth/onboarding state - Style the Android navigation bar with expo-navigation-bar - Use contentContainerClassName in the sign-up form
fernandatoledo
requested review from
amaury901130 and
asdolo
and
a balanced review from Copilot
November 18, 2026 21:49
There was a problem hiding this comment.
🟡 Changes recommended
The unchanged .nvmrc selects Node 20 for the documented setup, but the upgraded Expo 58 and React Native 0.88 packages require a newer supported runtime.
1 open issue
What changed in this PR
Overall Review: ai:serious
Upgrades the mobile template from Expo SDK 54 to SDK 58, adapting its navigation, native UI, TypeScript types, and test tooling.
Changes:
- Updates Expo, React Native, React, and development dependencies; raises the iOS minimum to 16.4.
- Adds explicit guard redirects and adjusts forms and WebView content for transparent headers.
- Migrates system bars and navigation imports, updates component typings, and adapts tests.
| File | Description |
|---|---|
tsconfig.json |
Removes baseUrl and explicitly includes Jest and Node types. |
src/lib/use-theme-config.tsx |
Moves theme imports to Expo Router entry points. |
src/lib/test-utils.tsx |
Removes the standalone navigation container from test wrappers. |
src/lib/auth/get-fallback-route.ts |
Selects fallback routes from onboarding and authentication state. |
src/components/ui/text.tsx |
Uses inferred flattened style types. |
src/components/ui/modal-keyboard-aware-scroll-view.tsx |
Uses inferred animated component types. |
src/components/ui/input.tsx |
Updates the input ref type. |
src/components/ui/focus-aware-status-bar.tsx |
Replaces edge-to-edge system bars with Expo components. |
src/components/ui/button.tsx |
Updates the button ref type. |
src/components/sign-up-form.tsx |
Adds automatic scroll insets and changes keyboard avoidance. |
src/components/settings/item.tsx |
Updates the settings item ref type. |
src/components/forgot-password-form.tsx |
Adds scrolling, automatic insets, and keyboard padding. |
src/app/www.tsx |
Enables automatic WebView content insets. |
src/app/update-password.tsx |
Adds scrolling, automatic insets, and keyboard padding. |
src/app/_layout.tsx |
Migrates navigation imports and adds explicit guard redirects. |
package.json |
Upgrades the SDK, native modules, and development tooling. |
jest.config.js |
Adds the Reanimated resolver, transform support, and worktree exclusions. |
eslint.config.mjs |
Excludes local Claude worktrees from linting. |
babel.config.js |
Removes the explicit Reanimated plugin. |
app.config.ts |
Raises the iOS minimum and removes obsolete configuration. |
AGENTS.md |
Updates documented dependency compatibility versions. |
__tests__/lib/auth/get-fallback-route.test.ts |
Covers all onboarding and authentication state combinations. |
__tests__/components/ui/progress-bar.test.tsx |
Adds a local animated-style helper type. |
__tests__/components/settings/item.test.tsx |
Simplifies the press-event target. |
Review effort: Balanced
# Conflicts: # package.json # pnpm-lock.yaml # src/app/_layout.tsx # src/lib/test-utils.tsx
amaury901130
approved these changes
Nov 19, 2026
7 tasks
|
✅ Good news! We ran Expo Doctor for this PR and everything looks good, Great job! |
💯 Test Coverage
😎 Tests Results
👀 Tests Details • (62%)
|
Expo 58 and React Native 0.88 require Node ^22.13.0. Point .nvmrc at v22.14.0 and have the EAS version check read it instead of hard-coding Node 20.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this do?
Upgrades the template from Expo SDK 54 to SDK 58 (React Native 0.88, React 19.3, TypeScript 6, Jest 30).
Dependencies
expo install --fixaligned every Expo-managed package with SDK 58. Notable majors:react-native-gesture-handler3,react-native-webview14,react-native-reanimated4.7,react-native-worklets0.13.react-native-mmkv4.0 → 4.3 andreact-native-nitro-modules0.31 → 0.37. Expo doesn't manage these, and the old versions crash at startup on RN 0.88 ("Failed to install Nitro"). MMKV 4.3 reads data written by 4.0, verified on an existing Android install.react-native-edge-to-edge(flagged as unmaintained by expo-doctor; edge-to-edge is built into RN now).FocusAwareStatusBarnow rendersexpo-status-barplusexpo-navigation-bar, so both system bars follow the theme asSystemBarsdid.jest-environment-jsdom30,ts-jest29.4 (supports Jest 30), and@types/nodedeclared explicitly.Config
newArchEnabled(default) and the explicit Reanimated Babel plugin (babel-preset-expoadds the worklets plugin).tsconfig: droppedbaseUrl(deprecated in TS 6) and settypes: ["jest", "node"](TS 6 no longer auto-includes@types)..claude/worktrees/so local Claude Code worktrees don't breakpnpm lint/pnpm test.react-native-reanimated/jest/resolver) so Reanimated 4.7 / Worklets 0.13 load their JS implementations in tests.Code
@react-navigation/*imports moved toexpo-routerentry points (required since SDK 56).Stack.Protectedguards now have an explicitredirectTo, computed bygetFallbackRoute(unit-tested for every onboarding/auth state). In SDK 58 a failed guard with noredirectTofalls back to the first unguarded route by file order, which sent users towww("Invalid Url") instead of onboarding.ScrollViewwithcontentInsetAdjustmentBehavior="automatic", wrapped in keyboard-controller'sKeyboardAvoidingView; thewwwWebView gets the same inset behavior.Why did you do this?
Keep the template on a supported SDK. SDK 55 and 56 were skipped on purpose: SDK 55 with Hermes V1, SDK 56, and SDK 57 before 57.0.9 have a Hermes V1 memory regression with Reanimated/Worklets.
Who/what does this impact?
expo-modules-jsi), andexpo-dev-launcher58.0.21 doesn't compile on Xcode 27.0: it callsaxisBehavior, an iOS 27.1 SDK API, behind#if compiler(>=6.4), which Xcode 27.0 passes while shipping the iOS 27.0 SDK. Xcode 27.1 needs macOS Tahoe 26.6+.ScrollViewwith automatic content insets, orheaderTransparent: false.Risk:
risk:highLarge dependency jump (4 SDKs, RN 0.81 → 0.88), native modules, and auth routing guards.
How did you test this?
pnpm type-check,pnpm lint,pnpm lint:translationsandpnpm test(143 tests) pass;expo-doctor20/20.iOS bundle and Android bundle export.
Tested on iOS (iPhone 17 Pro simulator, iOS 27, clean build with Xcode 27.1 and unmodified dependencies): fresh install → onboarding → sign in; MMKV persistence across restarts; empty-form validation; Forgot Password and Sign Up below the header; Sign Up keyboard.
Tested on Android (Pixel 8 emulator, Android 14): launch; existing MMKV data read; onboarding → sign in; validation; Sign Up layout and keyboard.
Tested on a small device
Tested on a real device
Tested all flows related with this PR changes. Logged-in screens weren't reachable (no backend in
.env).Tested accessibility
Added tests
Compared against
masterbuilt with the same Xcode and simulator to confirm the header overlap was introduced by SDK 58.Notes:
KeyboardAwareScrollView: with keyboard-controller 1.22.7 (Expo's pinned version) and Reanimated 4.7, its worklet handlers don't attach ("view tag can not be resolved"), so it doesn't react to the keyboard.modal-keyboard-aware-scroll-view(bottom sheets) is likely affected; not verified on device. 1.23.1 doesn't change that code path.progress-bar.test.tsxtypesgetAnimatedStylelocally: Reanimated 4.7 exposes the native signature only in its.native.d.ts, so TypeScript picks the web stub.forgot-password,sign-up); Sign Up reuses the "Password" label for the confirmation field; the "Forgot Password" link on Sign In is nearly invisible in dark mode.🤖 Generated with Claude Code