Repository navigation
fix: a 400 directLinkedIn.unknown to a LinkedIn send is outcome.unknown - #32
Merged
Merged
Conversation
Reply answers an exception escaping a LinkedIn send, and a provider answer it cannot map, as a 400 with the code directLinkedIn.unknown and a generic detail. The send may already be made, so mapping it to reply.refused told the caller nothing was sent when that is not known. On the send call of the four LinkedIn sends it is now outcome.unknown (exit 3), with status 400, Reply's code kept in reply_code, and the hint that a repeat may send it twice; a send Reply names in the answer stays under details. Under any other status, on send-email, and on the import of a send given a person's fields, the code maps as before. An email's exception is a 500, already outcome.unknown, and a 400 contact.emailSendingFailed stays a refusal. The help and the README say so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
contact linkedin-connect,linkedin-message,linkedin-inmail,linkedin-voice), a 400 with Reply's codedirectLinkedIn.unknownis nowoutcome.unknown(exit 3) instead ofreply.refused(exit 1). The error keeps status 400 and Reply's code inreply_code, and its hint is the one every lost send carries: running the command again may send it twice. A send Reply names in the answer (reference,state,send_after) stays underdetails, as on every other refusal of a send.codenorerrors[]isoutcome.unknowntoo.directLinkedIn.unknownmaps as before: under any status other than 400, oncontact send-email, and on the contact import that a send given a person's fields (--contact -) makes first.contact send-emailis unchanged. An exception escaping an email send is a 500, alreadyoutcome.unknown. A 400contact.emailSendingFailedsays the email was not sent and staysreply.refusedwith Reply's code kept.--helpand the README's section on the commands that are not safe to re-run name the new case.Why
Reply answers an exception escaping a LinkedIn send with a 400
directLinkedIn.unknownand a generic detail, and it uses the same code for a provider answer it cannot map. In either case the send may already have been made. Reported asreply.refused, it told the caller that nothing was sent, and an agent acting on that could send the same message twice.outcome.unknownis the CLI's answer for "the send may or may not have been made", and its hint says to check before repeating.How it was verified
npm run build && npm test: before, 924 passed and 5 skipped; after, 928 passed and 5 skipped. The commit was also built and tested in a clean detached worktree.reply.refused, and the named send's details went with it), and the help assertion failed before the help text changed.directLinkedIn.unknownisoutcome.unknown, exit 3, status 400,reply_codekept, one call, and the hint says a repeat may send it twice;referenceandstatekeeps them underdetails;reply.refused,access.denied,reply.refused) on each LinkedIn send;send-emailanswering a 400directLinkedIn.unknownor a 400contact.emailSendingFailedisreply.refused, exit 1, Reply's code kept, one call;directLinkedIn.unknown, isreply.refusedand nothing is sent.fetchand uses a scratch configuration directory. No call reaches Reply.