Repository navigation
[www-authenticate] Annotate parse's return value type - #16718
Open
Dhairya-007 wants to merge 1 commit into
Open
Dhairya-007 wants to merge 1 commit into
Dhairya-007 wants to merge 1 commit into
Conversation
`parse` returned `CaseFoldedOrderedDict[Incomplete]`. The value stored
for each challenge is decided by one line of the implementation:
challenges[name] = (args and args[0]) or kwargs or None
so it is the single token when the challenge carries one, the parsed
key/value parameters otherwise, and None when the challenge is bare.
Checked against www-authenticate 0.9.2:
>>> parse('Basic realm="a", Bearer, Negotiate abc==')
CaseFoldedOrderedDict([('basic', {'realm': 'a'}),
('bearer', None),
('negotiate', 'abc==')])
Annotated as `str | dict[str, str] | None`, which lets callers narrow
the three cases instead of getting `Any`.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parsereturnedCaseFoldedOrderedDict[Incomplete], so every challenge value came back asAny.The value type is fully determined by one line of the implementation:
It is the single token when the challenge carries one, the parsed key/value parameters otherwise, and
Nonewhen the challenge is bare. Checked against www-authenticate 0.9.2:>>> parse('Basic realm="a", Bearer, Negotiate abc==') CaseFoldedOrderedDict([('basic', {'realm': 'a'}), ('bearer', None), ('negotiate', 'abc==')])Annotated as
str | dict[str, str] | Noneso callers can narrow the three cases:The now-unused
Incompleteimport is dropped. Verified withmypy --strict.