Repository navigation
[networkx] Allow scalar values in set_edge_attributes and set_node_attributes - #16698
Open
hrithiksaini99 wants to merge 1 commit into
Open
hrithiksaini99 wants to merge 1 commit into
hrithiksaini99 wants to merge 1 commit into
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16542.
In
networkx,set_edge_attributes(G, values, name=None)andset_node_attributes(G, values, name=None)support setting an attribute to a scalar value (e.g.nx.set_edge_attributes(G, 5, "weight"),nx.set_node_attributes(G, "red", "color")). Whennameis provided andvaluesis not a dictionary, NetworkX treatsvaluesas a constant attribute value applied to all edges or nodes.Previously,
set_edge_attributesandset_node_attributesonly acceptedSupportsItemswhennamewas supplied, causing mypy to reject valid scalar values with:This PR:
values: objectwhenname: strinset_edge_attributesandset_node_attributes(matching both scalar constants and dicts).MultiGraphandGraphwhenname: None = None.check_tricky_function_params-py312.pyverifying scalar and dictionary attribute calls on graphs and multigraphs.