Repository navigation
fix(build): title GitHub releases with the semantic version only #4114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jmcouffin
wants to merge
1
commit into
develop
Choose a base branch
from
fix/release-title-semver
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+36
−3
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,16 @@ | ||
| namespace Build.Models; | ||
|
|
||
| /// <summary> | ||
| /// Version strings for one build, all derived from the stamped build version. | ||
| /// </summary> | ||
| /// <param name="BuildVersion">Full version with build metadata, such as <c>7.1.0.26319+1907</c>; used for tags.</param> | ||
| /// <param name="InstallVersion">Version without the <c>+HHmm</c> metadata, such as <c>7.1.0.26319</c>; used for installer names.</param> | ||
| /// <param name="BuildVersionUrlSafe"><paramref name="BuildVersion"/> with <c>+</c> encoded for URLs.</param> | ||
| /// <param name="IsWip">True for WIP channel builds.</param> | ||
| /// <param name="SemanticVersion"><c>major.minor.patch</c> only, such as <c>7.1.0</c>; the public release title uses it.</param> | ||
| public sealed record VersionInfo( | ||
| string BuildVersion, | ||
| string InstallVersion, | ||
| string BuildVersionUrlSafe, | ||
| bool IsWip); | ||
| bool IsWip, | ||
| string SemanticVersion); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
UnitandHostFreemetadata to the two newCreateVersionInfotests.Neither new test declares effective
LevelorEnvironmentmetadata. No class, project, or directory default supplies it, andVersionHelperTestshas no class-level category. The repository testing policy requires both values for every automated test underbuild/tests/.Both tests call only the in-memory
VersionHelper.CreateVersionInfomethod, soLevel=UnitandEnvironment=HostFreeare accurate. Set the tags on each method. Do not set them at class level. Other tests in this class modify environment variables, so a class-level tag would misclassify them.Suggested fix
Source: Coding guidelines