Repository navigation
🐛 fix(api): restore virtualenv public interface - #3548
Merged
Merged
Conversation
gaborbernat
force-pushed
the
fix/restore-simplint-exports
branch
4 times, most recently
from
November 13, 2026 01:49
a0f2e10 to
e15c358
Compare
gaborbernat
changed the title
The simplint migration moved public definitions into new modules, renamed importable names, and narrowed public annotations. Reexports preserved imports but changed the module identity of public objects. Restore the original definition locations, signatures, exports, and plain tuple return from run_cmd. Keep wheel generation aligned with the restored package module so later upgrades retain the same interface.
gaborbernat
force-pushed
the
fix/restore-simplint-exports
branch
from
November 13, 2026 01:53
e15c358 to
9d0d7e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simplint adoption (#3531, #3543) changed virtualenv's public Python interface: some importable names disappeared, annotations narrowed, and definitions moved to new modules. This restores the earlier interface for integrations that import or inspect these objects.
Public definitions again live in their original packages. Wheel regeneration uses the same package module, and narrow inline lint exceptions preserve these existing APIs.
run_cmdagain returns a plain tuple. The__all__lists retain their original entries; the addedTypeData,PathLockBase, andProcessCallFailedErrorexports have source importers.