Repository navigation
Fix StandardScaler.fit_transform - #96
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StandardScaler().fit_transform(x)raises aTypeError: the inherited method passesdimtofit(), butStandardScaler.fit()does not accept it.This adds a
fit_transform()override that uses the configuredaxisby default. Both methods accept an explicitdimfor a single fit without changingaxis.Added 12 regression cases for axis selection, float32/float64, inverse transforms, and invalid dimensions. All 12 fail on the previous code.
Checked locally with Python 3.11.15 and PyTorch 2.15.0:
The data tests were run by explicit file path because the default pytest options skip
tests/data.