Skip to content

fix(frontend): drop the redundant fragment in the Git panel - #449

Merged
polterguy merged 1 commit into
masterfrom
fix/gitpanel-redundant-fragment
Nov 21, 2026
Merged

polterguy merged 1 commit into
masterfrom
fix/gitpanel-redundant-fragment

Conversation

@EbubeEvan

@EbubeEvan EbubeEvan commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fixes the SonarCloud issue on master: "A fragment with only one child is redundant" (typescript:S6749) in frontend/src/components/GitPanel.tsx.

The "This folder is not a Git repository." message was wrapped in a <>…</> fragment with only that one line inside. The line now renders on its own:

{!busy && mode === 'norepo' && <p>This folder is not a Git repository.</p>}

Nothing changes on screen.

Test plan

  • Prettier, ESLint and tsc pass
  • Git panel tests (67) and the full suite (2808) pass

🤖 Generated with Claude Code

Checked

  • dotnet build magic.sln passes, which includes the analyzer rules, and dotnet test magic.sln passes
  • cd frontend && npm run build && npm run test passes, if the frontend changed
  • The README of the plugin is updated, if a slot, or the way one is used, changed
  • backend/files/config/appsettings.json is not part of the change

The "not a Git repository" message was wrapped in a fragment holding a
single child, which Sonar flags (typescript:S6749).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@EbubeEvan
EbubeEvan requested a review from polterguy as a code owner November 21, 2026 16:09
@sonarqubecloud

Copy link
Copy Markdown

@polterguy
polterguy merged commit f11ce5e into master Nov 21, 2026
9 checks passed
@EbubeEvan
EbubeEvan deleted the fix/gitpanel-redundant-fragment branch November 21, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants