Repository navigation
Fix/hyper ide toolbar stable layout - #446
Merged
Merged
Conversation
The IDE header showed the full file path and up to six buttons in one wrapping row, so when it ran out of room the toolbar wrapped or shifted as the unsaved marker appeared and Save lit up. - Show only the file name, with the full path in its tooltip, and keep a fixed slot for the unsaved marker. - Add a reusable overflow Toolbar: actions that don't fit move into a "more" menu instead of wrapping. What fits depends only on the room and on which actions exist, never on their state. Save is pinned. - Move the Web Designer's Menu to components/ so both share it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The editor tab already names the file, so the header shows the full path again, cut from the left when it doesn't fit so its end stays readable, and capped at half the header so it can't crowd out the toolbar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem
The Hyper IDE toolbar jumped around. The header put the title, the full file path and up to six buttons in one wrapping row. When the row ran out of room, the toolbar wrapped or shifted as the unsaved marker (
•) appeared and Save became enabled.Fix
components/Toolbar.tsx): when the buttons don't fit, the leftmost ones move into a "⋯" menu instead of wrapping. What fits depends only on the space available and on which buttons exist, never on their state, so Save becoming enabled or showing "Saving…" can't move anything. Save is pinned and never moves into the menu.…/modules/crm/foo.get.hl), so its end stays readable. It takes at most half the header. The unsaved marker has a fixed slot and is only shown or hidden.Menumoved fromcomponents/designer/tocomponents/, so the IDE and the designer use the same "more" menu. Its imports are updated; it behaves the same.Testing
components/test/Toolbar.test.tsx: the fitting logic, buttons moving into the menu when the row is narrow, the pinned button staying, re-fitting on resize, and a change in Save's state not moving anything..hlendpoint file and narrow the window.🤖 Generated with Claude Code
Checked
dotnet build magic.slnpasses, which includes the analyzer rules, anddotnet test magic.slnpassescd frontend && npm run build && npm run testpasses, if the frontend changedbackend/files/config/appsettings.jsonis not part of the change