Skip to content

feat: replace the launch profiler with the Inspector's Performance tab #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kpal81xd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: replace the launch profiler with the Inspector's Performance tab #2500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@jsquash/webp": "1.5.0",
"@playcanvas/eslint-config": "3.0.0",
"@playcanvas/font-tools": "0.1.2",
"@playcanvas/inspector": "0.3.0",
"@playcanvas/inspector": "0.5.0",
"@playcanvas/msdfgen-wasm": "0.1.1",
"@playcanvas/observer": "1.7.1",
"@playcanvas/pcui": "6.1.5",
Expand Down
220 changes: 0 additions & 220 deletions sass/launch.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,10 @@
@use 'sass:color';

$devtools-dark: #202020;
$devtools-bg: #303030;
$devtools-font: 'Courier New', monospace;

@font-face {
font-family: inconsolatamedium;
src: url('../static/fonts/Inconsolata-webfont.woff2') format('woff2');
font-weight: normal;
font-style: normal;
}

@font-face {
font-family: pc-icon;
src: url('../static/fonts/PlayIcons-Regular.woff2') format('woff2');
font-weight: normal;
font-style: normal;
}

html {
height: 100%;
width: 100%;
Expand Down Expand Up @@ -143,210 +130,3 @@ canvas:focus {
right: 5px;
top: 5px;
}

%no-select {
user-select: none;
}

%font-icon {
font-family: pc-icon;
}

body > #dev-tools {
position: absolute;
z-index: 10001;
bottom: 0;
left: 0;
right: 0;
width: auto;
height: 300px;
background-color: $devtools-bg;
overflow: hidden;
cursor: default;
border-top: 1px solid $devtools-dark;

&.dragging {
cursor: grabbing;
}

> .overview {
position: absolute;
left: 300px;
top: 0;
display: block;
background-color: $devtools-dark;

@extend %no-select;
}

> .timeline {
position: absolute;
left: 300px;
top: 24px;
display: block;
background-color: $devtools-bg;

@extend %no-select;
}

> .frame {
position: absolute;
top: 0;
left: 0;
width: 299px;
height: 300px;
border-right: 1px solid $devtools-dark;
overflow: auto;
color: #fff;
font-size: 12px;
font-family: $devtools-font;

&::-webkit-scrollbar {
width: 4px;
height: 4px;
}

&::-webkit-scrollbar-track {
background: $devtools-bg;
}

&::-webkit-scrollbar-thumb {
background: $devtools-dark;
}

&::-webkit-scrollbar-thumb:hover {
background: #fff;
}

&::-webkit-scrollbar-corner {
background: $devtools-bg;
}

> .panel {
overflow: hidden;

> .header {
text-transform: uppercase;
height: 24px;
line-height: 24px;
padding: 0 8px;
font-size: 14px;
background-color: $devtools-dark;
cursor: pointer;
}

> .row {
overflow: hidden;
margin: 4px 8px;

> .title {
float: left;
width: 150px;
}

> .field {
float: left;
}

> select {
padding: 0;
margin: 0;
border: none;
width: calc(100% - 150px);
background-color: $devtools-dark;
color: #fff;
font-size: 12px;
font-family: $devtools-font;
}

> input[type='text'] {
float: left;
padding: 4px 8px;
margin: 0;
border: none;
background-color: $devtools-dark;
color: #fff;
font-size: 12px;
line-height: 16px;
font-family: $devtools-font;

&.framesSkip {
width: calc(100% - 140px - 16px);
margin-right: 4px;
}
}

> .drawcallsLimitButton {
float: left;
width: 24px;
height: 24px;
line-height: 24px;
text-align: center;
margin-right: 4px;
background-color: $devtools-dark;
color: #fff;
cursor: pointer;

&:hover {
background-color: #000;
}

&:last-child {
margin-right: 0;
}
}
}

&.folded {
height: 24px;

> .header {
color: color.mix($devtools-dark, #fff, 50%);
}
}
}
}

> .toolbar {
position: absolute;
top: 0;
right: 0;
bottom: 0;
width: 32px;
background-color: $devtools-dark;

> .button {
width: 32px;
height: 32px;
line-height: 32px;
text-align: center;
color: #fff;
font-size: 16px;
cursor: pointer;

@extend %font-icon;

&:hover {
background-color: #000;
}
}
}

&.minimized {
width: 32px;
height: 32px;
left: auto;
border-top: none;

> .overview,
> .timeline,
> .frame {
display: none;
}

> .toolbar {
position: static;
height: 32px;
}
}
}
2 changes: 1 addition & 1 deletion src/editor/viewport-controls/viewport-launch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ editor.once('load', () => {
const optionProfiler = createOption('profiler', 'Profiler');
const tooltipProfiler = TooltipHandle.attach({
target: optionProfiler.parent.dom,
text: 'Enable the visual performance profiler in the launch page.',
text: 'Open the Inspector on its Performance tab, recording from the start of the application. Requires Engine 2.23 or later.',
align: 'right',
root: root
});
Expand Down
7 changes: 0 additions & 7 deletions src/launch/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,6 @@ import './viewport/viewport';
import './viewport/viewport-error-console';
import './viewport/viewport-tooltip';

// tools
import './tools/tools';
import './tools/tools-overview';
import './tools/tools-timeline';
import './tools/tools-frame';
import './tools/tools-toolbar';

// entities
import './entities/entities';
import './entities/entities-sync';
Expand Down
Loading
Loading