Repository navigation
Conversation
…ine break Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
line-break-charsis set,php_conv_qprint_encode_convert()holds back characters that may start a line break sequence. If a write ended in the middle of such a sequence:lb_cnt, so when the next write completed the sequence the line break was emitted again ("Hello=\r"followed by"\nWorld"decodes to"Hello=\r\r\nWorld");"a\r"encodes to"a").This change keeps a partial line break pending at the end of the input until more data arrives, and emits it on the final flush (NULL input), which the converter previously ignored. The trailing whitespace lookahead is skipped when no input is left so it never reads from the NULL input pointer during the flush.
Output for input that does not end in a partial line break is unchanged. Added a test with single and split writes; every case now decodes back to the original data.
Fixes #24462