Repository navigation
Conversation
run-e2e.sh resolved its own directory via an unset variable, so it ran `cd ""`. Older bash treats that as a no-op, but bash 5.3 on the ubuntu-26.04 runner fails with "cd: null directory", leaving SCRIPT_PATH empty and no suites found. Signed-off-by: Lukas Hirt <info@hirt.cz>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Collaborator
Author
|
Folded into #13968. Neither change can pass CI on ubuntu-26.04 without the other. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/e2e/run-e2e.shresolved its own directory withcd "${SCRIPT_PATH_REL}". That variable isn't set at that point, so the script rancd "". Older bash treats an emptycdas a no-op, and CI starts the script fromtests/e2e, so the bug never showed. bash 5.3 on the ubuntu-26.04 runner rejects it:This uses
${SCRIPT_PATH}as intended, which matches the copy of the script in ocis.Reproduced and verified in an
ubuntu:26.04container (bash 5.3.9) withpnpmstubbed: before, it fails as above; after, it resolvestests/e2e/cucumber/features/smoke.Needed together with #13968 to get e2e running on ubuntu-26.04.