Repository navigation
fix(ci): stop the docs-only filter skipping checks that depend on the change - #13471
Open
oc-tmueller wants to merge 2 commits into
Open
oc-tmueller wants to merge 2 commits into
oc-tmueller wants to merge 2 commits into
Conversation
detect-changes treats some paths as docs-only even though checks depend on them, so PRs touching only those paths skipped the checks and the required gate passed: - deployments/examples/ocis_ldap/config/ldap holds the LDAP seed and schemas that the external LDAP acceptance tests mount (tests/ldap-smoke/run.sh, tests/ldap-smoke-distributed/docker-compose.yml). A change there now runs the acceptance tests. The rest of deployments/ stays docs-only; the deployment examples have their own deployment-test workflow. - changelog/* is docs-only, but changelog-lint ran only inside build-and-test, so changelog-only PRs were never linted. Run it in detect-changes instead, for every PR. A lint failure still keeps the test jobs from starting, as it did via build-and-test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: oc-tmueller <323649642+oc-tmueller@users.noreply.github.com>
- all-acceptance-tests exited 0 on docs-only before looking at any result, so a failing changelog lint in detect-changes did not block a changelog-only PR. Fail the gate first when detect-changes did not succeed. - git diff --name-only lists only the new path of a rename, so moving a code or LDAP fixture file into docs/ or deployments/ counted as docs-only. Use --no-renames so both paths are classified. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: oc-tmueller <323649642+oc-tmueller@users.noreply.github.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
LukasHirt
approved these changes
Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
detect-changesclassifies a PR as docs-only from its changed paths. Docs-only skipsbuild-and-testand everyacceptance job, and the required
all-acceptance-testsgate passes. Some paths it treats as docs are inputs tochecks:
deployments/examples/ocis_ldap/config/ldap/holds the LDAP seed and schemas that the external LDAPacceptance tests mount (
tests/ldap-smoke/run.sh,tests/ldap-smoke-distributed/docker-compose.yml). A PRthat changes only those files skips the very tests that use them.
changelog/*is docs-only, butmake changelog-lintran only insidebuild-and-test, so changelog-onlyPRs were never linted.
git diff --name-onlylists only a renamed file's new path, so moving a file intodocs/ordeployments/counted as docs-only.Fix
deployments/examples/ocis_ldap/config/ldap/makes the PR non-docs-only. The rest ofdeployments/stays docs-only; the deployment examples have their owndeployment-test.yml.make changelog-lintmoves frombuild-and-testto a step indetect-changes, so it runs on every PR. It isplain shell (no toolchain), and every one of the 1,702 current entries passes.
detect-changesdid not succeed. Before, it exited 0 on docs-only without lookingat any result, so the lint would not have been enforced.
git diff --no-renames, so a rename is classified by both its old and new path.A lint failure on a code PR still keeps the test jobs from starting, as it did through
build-and-test. A puredocs move out of a code directory now runs full CI; that is the conservative side of the rename fix.
Related: #13469 fixes the same gate passing when
build-and-testitself fails. Both PRs edit the gate step inadjacent places, so whichever merges second needs a trivial rebase.
🤖 Generated with Claude Code