Repository navigation
docs: enable the bundled html-editor web app in ocis_full - #13320
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
html-editor ships with oCIS but is not in the default list of bundled web apps. Override the list via web.yaml, keeping the current defaults and adding html-editor. Signed-off-by: Lukas Hirt <info@hirt.cz>
39d55f8 to
80734fb
Compare
dj4oC
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
@LukasHirt Verified the override list in config/ocis/web.yaml matches the built-in defaults exactly (services/web/pkg/config/defaults/defaultconfig.go:101: files, search, text-editor, mermaid-editor, pdf-viewer, external, admin-settings, epub-reader, preview, app-store) plus html-editor. The mount follows the same pattern as the existing csp.yaml/app-registry.yaml mounts in ocis.yml, and docker compose config renders cleanly. The "keep in sync with defaults" comment in the new file is the right mitigation for the duplication. CI on head: 10 checks success, 17 skipped (docs-only gating), no failures.
Description
Overrides the bundled web app list via
config/ocis/web.yamlto addhtml-editor, keeping the current defaults.Motivation and Context
html-editorships with oCIS but is not part of the default list of bundled web apps. The override has to repeat the defaults (services/web/pkg/config/defaults/defaultconfig.go) and needs to be kept in sync with them.Part of splitting the
ocis_fullweb-extensions work into single-responsibility PRs.How Has This Been Tested?
docker compose configrenders theocis_fullexample without errors.Types of changes