Skip to content

docs: enable the bundled html-editor web app in ocis_full - #13320

Merged
LukasHirt merged 2 commits into
masterfrom
docs-ocis-full-enable-html-editor
Nov 13, 2026
Merged

LukasHirt merged 2 commits into
masterfrom
docs-ocis-full-enable-html-editor

Conversation

@LukasHirt

Copy link
Copy Markdown
Contributor

Description

Overrides the bundled web app list via config/ocis/web.yaml to add html-editor, keeping the current defaults.

Motivation and Context

html-editor ships with oCIS but is not part of the default list of bundled web apps. The override has to repeat the defaults (services/web/pkg/config/defaults/defaultconfig.go) and needs to be kept in sync with them.

Part of splitting the ocis_full web-extensions work into single-responsibility PRs.

How Has This Been Tested?

  • docker compose config renders the ocis_full example without errors.
  • The full stack was not started for this PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@LukasHirt
LukasHirt requested a review from a team as a code owner November 4, 2026 11:32
@LukasHirt LukasHirt self-assigned this Nov 4, 2026
@update-docs

update-docs Bot commented Nov 4, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kw-security

kw-security commented Nov 4, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

html-editor ships with oCIS but is not in the default list of bundled web
apps. Override the list via web.yaml, keeping the current defaults and
adding html-editor.

Signed-off-by: Lukas Hirt <info@hirt.cz>
@LukasHirt
LukasHirt force-pushed the docs-ocis-full-enable-html-editor branch from 39d55f8 to 80734fb Compare November 5, 2026 17:11
@LukasHirt
LukasHirt requested a review from dj4oC November 5, 2026 17:12

@dj4oC dj4oC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

@LukasHirt Verified the override list in config/ocis/web.yaml matches the built-in defaults exactly (services/web/pkg/config/defaults/defaultconfig.go:101: files, search, text-editor, mermaid-editor, pdf-viewer, external, admin-settings, epub-reader, preview, app-store) plus html-editor. The mount follows the same pattern as the existing csp.yaml/app-registry.yaml mounts in ocis.yml, and docker compose config renders cleanly. The "keep in sync with defaults" comment in the new file is the right mitigation for the duplication. CI on head: 10 checks success, 17 skipped (docs-only gating), no failures.

@LukasHirt
LukasHirt merged commit 41f0467 into master Nov 13, 2026
32 checks passed
@LukasHirt
LukasHirt deleted the docs-ocis-full-enable-html-editor branch November 13, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants