Repository navigation
oci-javascript-mcp-server: tool contract improvements - #495
Merged
dustin-sale merged 5 commits intoNov 4, 2026
Merged
dustin-sale merged 5 commits into
dustin-sale merged 5 commits into
Conversation
dustin-sale
marked this pull request as ready for review
October 19, 2026 13:40
dustin-sale
requested review from
AlaaShaker,
gebhardtr and
krisrice
as code owners
October 19, 2026 13:40
Signed-off-by: Dustin Sale <dustin.sale@oracle.com>
This was referenced Nov 2, 2026
robander
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve the OCI JavaScript MCP server’s tool contracts so clients can discover valid inputs and outputs, identify execution failures, and use SDK discovery without silently falling back to a shallower level.
src/tool-contracts.ts.run_javascriptexecutions with MCPisError: truewhile preserving the six structured result fields and matching JSON text content.Breaking changes:
isErrorflag for failed executions.discover_ociinputs that previously fell back to a shallower discovery level now return tool errors.Tracking issue: Not identified in the branch; add the issue reference before submission.
Dependencies: No package dependency changes or dependent PRs identified.
Type of change
How Has This Been Tested?
The branch adds tests covering:
Run from the repository root:
moon run oci-javascript-mcp-server:test— run unit and integration tests with the configured 90% line-coverage gate.moon run oci-javascript-mcp-server:check— check TypeScript source and test types.moon run oci-javascript-mcp-server:build— validate npm package creation.These tests use mocked OCI behavior and a fake Podman control plane; real OCI operations and Podman deployment isolation remain unverified.
Test Configuration:
@modelcontextprotocol/sdk ^1.31.0,oci-sdk ^2.132.0, andzod ^4.4.3.Checklist:
No dependent module changes were identified. Author self-review, passing validation, Oracle Contributor Agreement status, and the required commit signoff remain unverified.