Repository navigation
feat(api): add degraded external storage status - #1214
Conversation
Castiron-Internal-PR: openai/openai-java-internal#299 Castiron-Source-SHA: 7b890158763f8bf9135a30fb42cbee4aa43b5c41 Castiron-Public-Base-SHA: 690835d
|
Reviewer note: this also stabilizes the existing Live transcript overlap tests. A 50 ms reorder timer could run between two test events, producing a valid assistant segment that the old test did not expect. The repair adds a per-instance internal clock/scheduler hook and tests both event-first and timer-first orderings. Public builders retain the same scheduler, clock, grouping rules, and timeouts. Local validation: all 39 transcript-grouping tests and 21 WebSocket lifecycle tests passed; repository formatting passed. No tests are skipped or quarantined. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 98 mixed files remain; 0 existing customizations changed. Compared 98 existing customizations unchanged
58 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 39060599996 --repo openai/openai-java \
--name castiron-custom-code-39060599996-1 --dir /tmp/castiron-custom-code-39060599996-1
git apply --stat /tmp/castiron-custom-code-39060599996-1/custom-code.patch
cat /tmp/castiron-custom-code-39060599996-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 690835d2b1ad8ca094d8a51052f47cac10cb54ff 693fa284c17fb805a5eb9d2d86cfa03d26bf6cb7
python3 scripts/castiron/custom_code_report.py report \
--base 690835d2b1ad8ca094d8a51052f47cac10cb54ff \
--head 693fa284c17fb805a5eb9d2d86cfa03d26bf6cb7 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-693fa284c17f
cat /tmp/castiron-custom-code-693fa284c17f/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed 693fa284c17fb805a5eb9d2d86cfa03d26bf6cb7. No actionable findings.
The degraded status is present in both enum mappings and the schema. The timer repair supplies a clock and scheduler per test instance while preserving the public factories and production defaults. The tests cover both event-first and timer-first ordering; cancellation, callback dispatch and close behavior remain intact. The small internal test hook avoids global state and needs no broader scheduling framework.
Validation: reviewed the complete 6-file diff and relevant surrounding code. 17 hosted checks passed; 2 were skipped. I did not execute candidate code locally.
2 participants
Summary
Recognize degraded as an external storage status.
Changes