Skip to content

fix(core): make generator output ordering deterministic - #1193

Merged
ovflowd merged 6 commits into
nodejs:mainfrom
OKAN-SOFTWARE:fix/1183-deterministic-generator-order
Oct 29, 2026
Merged

ovflowd merged 6 commits into
nodejs:mainfrom
OKAN-SOFTWARE:fix/1183-deterministic-generator-order

Conversation

@OKAN-SOFTWARE

Copy link
Copy Markdown
Contributor

Summary

Fixes #1183.

  • Preserve input order when collecting parallel worker results, without sacrificing concurrent task execution.
  • Sort Markdown and JavaScript files before processing to ensure deterministic output.
  • Add regression tests for ordering and worker failures.
  • Include a patch changeset for @doc-kit/core.

Validation

  • Focused tests on Windows (Node.js 24): 26 passed, 0 failed.
  • Lint: 0 warnings, 0 errors.
  • The full test suite encountered failures in the TypeDoc package. The adapted-URL test failure was reproduced separately on the unchanged main branch and is unrelated to this fix.

Notes

PRs #1179 and #1180 modify related threading and file-discovery code. This change is based on the current implementation and may require coordination if either PR merges first.

@OKAN-SOFTWARE
OKAN-SOFTWARE requested a review from a team as a code owner October 27, 2026 15:04
@vercel

vercel Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api-docs-tooling Ready Ready Preview Oct 29, 2026 2:20pm UTC

Request Review

@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.42%. Comparing base (9e21017) to head (37db764).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1193      +/-   ##
==========================================
+ Coverage   93.32%   93.42%   +0.09%     
==========================================
  Files         285      286       +1     
  Lines       28374    28502     +128     
  Branches     2847     2870      +23     
==========================================
+ Hits        26481    26628     +147     
+ Misses       1871     1852      -19     
  Partials       22       22              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

api-links Generator

Performance estimate (single CI run)

  • Generation time: 4.7% slower (1.06 s → 1.11 s)
  • Peak memory: 6.6% higher (286.05 MB → 304.80 MB)

json Generator

Performance estimate (single CI run)

  • Generation time: 1.8% slower (10.18 s → 10.36 s)
  • Peak memory: 2.0% higher (1.12 GB → 1.14 GB)

legacy-html Generator

Performance estimate (single CI run)

  • Generation time: 66.6% slower (10.64 s → 17.73 s)
  • Peak memory: 5.3% lower (1.77 GB → 1.67 GB)

legacy-json Generator

Performance estimate (single CI run)

  • Generation time: 23.6% faster (6.90 s → 5.27 s)
  • Peak memory: 4.1% higher (1.17 GB → 1.21 GB)

llms-txt Generator

Performance estimate (single CI run)

  • Generation time: 19.6% faster (7.81 s → 6.28 s)
  • Peak memory: 7.8% higher (1.08 GB → 1.17 GB)

orama-db Generator

Output size: 1 file changed · net +1.68 KB

File size details
File Main PR Change
orama-db.json 29.24 MB 29.24 MB +1.68 KB (+0.0%)

Performance estimate (single CI run)

  • Generation time: 26.2% faster (9.39 s → 6.93 s)
  • Peak memory: 4.2% higher (1.22 GB → 1.28 GB)

web Generator

Performance estimate (single CI run)

  • Generation time: 2.4% faster (23.71 s → 23.15 s)
  • Peak memory: 3.5% higher (1.96 GB → 2.03 GB)

@ovflowd

ovflowd commented Oct 29, 2026

Copy link
Copy Markdown
Member

@OKAN-SOFTWARE could you rebase your PR?

@OKAN-SOFTWARE

Copy link
Copy Markdown
Contributor Author

@OKAN-SOFTWARE could you rebase your PR?

Rebased onto the latest main and force-pushed the updated branch. All merge conflicts are resolved.

Local validation:

  • 26 focused tests passed, 0 failures
  • Formatting checks passed
  • Lint completed with 0 errors
  • Working tree clean

The GitHub Actions workflows currently show action_required. Could a maintainer approve the workflow runs so CI can proceed?

Thanks for the review!

@ovflowd
ovflowd merged commit 854a944 into nodejs:main Oct 29, 2026
23 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 29, 2026

This branch was successfully deployed

1 active deployment
Preview – api-docs-tooling — 37db7642 Deployed Oct 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

core: output order changes between builds

4 participants