Skip to content

fix: allow sidebar buttons to move into navigation overflow #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marinofaggiana merged 1 commit into from
Oct 23, 2026
Merged

fix: allow sidebar buttons to move into navigation overflow #4418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions iOSClient/Main/NCMainNavigationController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,11 +300,9 @@ class NCMainNavigationController: UINavigationController, UINavigationController
if let loadingItem, loadingIndicator?.isAnimating == true {
items.append(loadingItem)
}
// Match Media: each item has its own group; only the sidebar is always available.
// Each item can move independently into UIKit's overflow menu.
navigationItem.leadingItemGroups = items.map { item in
let group = UIBarButtonItemGroup(barButtonItems: [item], representativeItem: nil)
group.alwaysAvailable = item === sidebarButtonItem
return group
UIBarButtonItemGroup(barButtonItems: [item], representativeItem: nil)
}
}

Expand Down
4 changes: 1 addition & 3 deletions iOSClient/Media/NCMediaNavigationController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,7 @@ class NCMediaNavigationController: NCMainNavigationController {
items.append(media.searchActivityBarButtonItem)
}
media.navigationItem.leadingItemGroups = items.map { item in
let group = UIBarButtonItemGroup(barButtonItems: [item], representativeItem: nil)
group.alwaysAvailable = item === sidebarButtonItem
return group
UIBarButtonItemGroup(barButtonItems: [item], representativeItem: nil)
}
}

Expand Down
Loading