Skip to content

fix(transifex): Translate viewer only until stable35 #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Oct 21, 2026
Merged

fix(transifex): Translate viewer only until stable35 #1013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions translations-app/handleAppTranslations.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,13 @@ gpg --allow-secret-key-import --import /gpg/nextcloud-bot.asc
gpg --list-keys

# fetch git repo
git clone git@github.com:$1/$2 /app/default --depth 1
# the main branch of the viewer app is a library without translations,
# so only its hardcoded stable branches are translated
DEFAULT_BRANCH_ARG=''
if [ "$2" = 'viewer' ]; then
DEFAULT_BRANCH_ARG='--branch stable35'
fi
git clone git@github.com:$1/$2 /app/default --depth 1 $DEFAULT_BRANCH_ARG

cd default

Expand Down Expand Up @@ -76,10 +82,9 @@ versions='main master stable35 stable34 stable33'
if [ -f '.tx/backport' ]; then
versions="main master $(cat .tx/backport)"
fi

if [ "$APP_ID" = "viewer" ]; then
# the main branch of the viewer app must not be translated
versions="${versions#main }"
# only translate the stable branches of the viewer app that are still translated globally
versions=$(echo "$versions" | tr ' ' '\n' | grep -xF -e stable35 -e stable34 -e stable33 | tr '\n' ' ')
fi

# During a string freeze no new strings may enter the translation system.
Expand All @@ -88,6 +93,9 @@ fi
# skipped completely and the newest stable branch defines the source strings.
STRING_FREEZE='false'
TEMPLATE_BRANCHES='master main'
if [ "$APP_ID" = "viewer" ]; then
TEMPLATE_BRANCHES='stable35'
fi
if is_string_freeze "$versions" && is_shipped_app "$APP_ID"; then
STRING_FREEZE='true'
TEMPLATE_BRANCHES=$(newest_stable_branch "$versions")
Expand Down