Repository navigation
Support anomaly investigation overlays in both time-series renderers - #240
Merged
Merged
Conversation
ktsaou
force-pushed
the
feat/anomaly-advisor-chart-overlays
branch
2 times, most recently
from
October 6, 2026 03:47
e14fbc3 to
c583dfb
Compare
ktsaou
marked this pull request as ready for review
October 7, 2026 08:18
novykh
force-pushed
the
feat/anomaly-advisor-chart-overlays
branch
from
October 15, 2026 05:37
ccae6cb to
8adff02
Compare
ktsaou
force-pushed
the
feat/anomaly-advisor-chart-overlays
branch
from
October 18, 2026 14:37
8adff02 to
ba76425
Compare
…ghts payloads once
…fetch layer replaces
novykh
force-pushed
the
feat/anomaly-advisor-chart-overlays
branch
from
October 20, 2026 09:32
564b7c7 to
0c90df4
Compare
novykh
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support the redesigned Anomalies investigation chart with both native time-series renderers, without pinning Dygraph or changing the dashboard's renderer policy.
enabledAnnotations, defaulting totrue(sameenabledXform asenabledHover/enabledNavigation). Strictfalsesuppresses saved/draft annotations and annotation-oriented click/tap behavior while preserving raw UI events for investigation selection. Other overlays and ordinary chart defaults remain unchanged.highlightOpacity(default1) in both renderers, clamped to[0, 1], without changing the highlighted range or leaking canvas state. ChangingenabledAnnotationsorhighlightOpacityredraws the native canvas.Base and scope
This companion is based on
mainatda91889cc, which includes the merged renderer PR #234. The PR diff contains only the companion extensions and this port, not the underlying renderer implementation. The old main-based head remains recoverable locally.No package version, dependency or release workflow is changed. No detection algorithm, Chat or dashboard-provider policy changes are included. Correlation (weights) queries do change; see "Behaviour changes for existing SDK users".
Validation
getDateDiff()declaration-order error and two grid CSS serialization assertions under the shared frontend test toolchain. No full charts-suite pass is claimed.main, not PR branches.Behaviour changes for existing SDK users
volumeandks2). Every weights request now uses an adaptive preceding baseline: 4× the window for windows under 1 hour, 2× under 6 hours, 1× otherwise (getCorrelationBaseline). For these two methods an explicitbaselineAfter/baselineBeforeis intentionally ignored (pinned bycorrelationBaseline.test.js).anomaly-rateandvaluekeep explicit baselines. Callers that sent no baseline used to compare a window with itself; they now compare it with the preceding window. The Correlate drawer moves from a fixed 4× baseline to the adaptive one. Fully relative live windows are anchored to the captured clock when one exists.clickUI event and setsclickXonly while annotations are enabled. Dygraph keeps its existing tap behavior (clickX, noclick) while annotations are enabled, and emitsclickwithoutclickXonly when they are disabled. Forwardingclickon every Dygraph tap would route taps into its click-to-pin/annotation path for existing users. Both renderers are pinned by tests.ui.on(...)on the old UI end when it unmounts (unmountclears its listeners), so consumers must re-subscribe onmountChartUI. The old UI is unmounted twice during a swap (by the SDK swap and byChartContainercleanup); the second call is harmless and firesunmountChartUIagain.pannavigation mode; drags and modifier gestures emit noclick. Dygraph clicks come from Dygraph's own click callback; their behavior in select/highlight modes is not covered by this PR.panEnd. This stops a click from replacing a short window with uPlot's expanded axis bounds, and applies to every chart rendered with uPlot.Review follow-ups in this PR
annotationsEnabledrenamed toenabledAnnotations(frontend consumers updated in the companion PR).enabledAnnotationsorhighlightOpacitychange;highlightOpacityhas a no-op default of1.usesAdaptiveBaselineexported; the Correlate drawer no longer computes a baseline that the fetch layer replaces.useChartUIhook replaces thechartLibraryattribute as the "UI replaced" signal in the five renderer-bound effects.Integration / release
Companion to frontend Anomalies PR #5889.
The currently published
7.0.0-alpha.1does not contain these extensions. Local frontend validation preserves SDK 7 and compiles only the required companion modules into the existing development installation; it does not replace SDK 7 with SDK 6 or certify a clean released-package installation.The PR remains draft and is not release-ready until these gates are satisfied.