Skip to content

Mirror platform artifacts so driver PDBs are retained - #645

Merged
nefarius merged 1 commit into
masterfrom
fix/mirror-pdb-artifacts
Nov 15, 2026
Merged

nefarius merged 1 commit into
masterfrom
fix/mirror-pdb-artifacts

Conversation

@nefarius

@nefarius nefarius commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Mirror each dshidmini-x64, dshidmini-ARM64, and dshidmini-x86 artifact to the buildbot immediately after upload. Those artifacts already contain the generated PDB files, including the driver symbols bin/x64/dshidmini.pdb and bin/ARM64/dshidmini.pdb.
  • Leave builds/DsHidMini/latest pointed at the signed ControlApp, and skip mirroring when the webhook secret is unavailable on a fork pull request.

Test plan

  • .\build.cmd TestReleasePipeline
  • Confirm the next non-fork Build run mirrors all three platform artifacts under job labels x64, ARM64, and x86.
  • Confirm the mirrored x64 and ARM64 jobs contain bin/x64/dshidmini.pdb and bin/ARM64/dshidmini.pdb, and that utility PDBs are present for every platform, including x86.
  • Confirm builds/DsHidMini/latest still points at the signed ControlApp used by the in-app updater.

Made with Cursor

Summary by CodeRabbit

  • Chores
    • Build artifacts are now mirrored for eligible builds when mirroring is configured. Fork-based pull request builds are excluded.
    • Artifact mirroring is labeled by platform, and the latest-version link is not updated by this process.

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The build workflow adds Actions read permission and webhook configuration. When the webhook is configured and the event conditions are met, the workflow sends the platform artifact to a pinned receiver.

Changes: Build Artifact Mirroring

Layer / File(s) Summary
Configure and mirror build artifacts
.github/workflows/build.yml
The build job exposes the webhook secret and requests Actions read permission. After uploading an artifact, it conditionally invokes the pinned receiver with the platform artifact and tokens. The step skips updating the latest symlink.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: Minimal · up to b6a26

This change mirrors the platform build artifacts, including driver PDBs, to the buildbot after upload and skips mirroring when the webhook secret is unavailable. No concrete defect was found. After merge, confirm that the receiver's target path template includes the run attempt so that reruns cannot overwrite a signed release directory.

Architecture risk: Low · up to b6a26

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/build.yml: The build job adds actions: read permission and promotes WEBHOOK_URL from secrets into the job environment; the existing vcpkg-token environment setting remains.
  • observed — Modified behavior in .github/workflows/build.yml: Adds a platform artifact mirror step after artifact upload. It runs only with a configured webhook and for non-fork pull requests (or non-pull-request events), passes the webhook and GitHub tokens, selects dshidmini-${{ matrix.platform }}, skips the latest symlink, and labels the upload with the platform.
Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Mirror platform artifacts so driver PDBs are retained" matches the main change. The build workflow now mirrors the platform-specific build artifacts (x64, ARM64, x86) through an AppVeyor ar…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Mirror platform artifacts so driver PDBs are retained" matches the main change. The build workflow now mirrors the platform-specific build artifacts (x64, ARM64, x86) through an AppVeyor artifacts receiver after upload, and the stated purpose is keeping the driver PDB files available for diagnostics. The title is specific and does not describe anything absent from the changeset. The title is a single, concise sentence that names the primary change.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit watches builds take flight,
Each platform packed and sealed just right.
A webhook guides the bundle through,
The mirror gets its artifact too.
Then fluffy paws hop off to chew.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8a1b48cf-e644-4f0d-99b0-0f97f1651cc6
Commits

Reviewing files that changed from the base of the PR and between b9f9dcb and b6a2664.

Files selected for processing: 1

  • .github/workflows/build.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

@nefarius
nefarius merged commit 01cc722 into master Nov 15, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant