Skip to content

Publish unsigned ControlApp and XInput builds - #641

Merged
nefarius merged 1 commit into
masterfrom
ci/publish-unsigned-tools
Nov 8, 2026
Merged

nefarius merged 1 commit into
masterfrom
ci/publish-unsigned-tools

Conversation

@nefarius

@nefarius nefarius commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Every trusted build publishes control-app-unsigned with ControlApp and the x64, x86, and ARM64 XInput DLLs.
  • The packed ZIP is mirrored for anonymous download and does not retarget the signed builds/DsHidMini/latest updater files.
  • Release signing now consumes that unsigned package and still publishes the signed control-app artifact.

Test plan

  • Confirm this pull request uploads control-app-unsigned containing bin/ControlApp.exe and bin/{x64,x86,arm64}/XInput1_3.dll.
  • Confirm the anonymous Buildbot URL downloads that ZIP.
  • Confirm https://buildbot.nefarius.at/builds/DsHidMini/latest/bin/ControlApp.exe still serves the signed release build.

Made with Cursor

Summary by CodeRabbit

  • Chores
    • Updated build and release packaging to provide unsigned tool builds alongside signed release builds.

The signed control-app package exists only on release tags, so a tester cannot download those binaries from a pull request.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The workflow adds an unsigned-tools job that checks, stages, and uploads unsigned tools. The release-only signing job downloads that artifact. ARM64 XInput paths in the signing workflow use lowercase arm64.

Changes: Unsigned tools and release signing

Layer / File(s) Summary
Create and publish unsigned tools
.github/workflows/build.yml
The new job downloads platform artifacts, checks and stages required unsigned files, uploads them, and conditionally mirrors the artifact.
Consume artifact and sign tools
.github/workflows/build.yml
The release-only signing job downloads the unsigned-tools artifact. ARM64 XInput checks, signing, and staging use lowercase arm64 paths.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · up to 8cf26

The unsigned package and release-signing flow appear consistent with the intended behavior. Normal workflow and download checks remain appropriate before release.

Architecture risk: Low · up to 8cf26

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/build.yml: Adds an unsigned-tools job dependent on build. It downloads platform artifacts, fails if any required ControlApp or XInput file is missing or signed, stages and uploads the unsigned files, and conditionally mirrors them when WEBHOOK_URL is set and the run is not a fork pull request. The release-only control-app job now depends on unsigned-tools instead of build and begins by downloading the unsigned-tools artifact.
  • observed — Modified behavior in .github/workflows/build.yml: The unsigned-signature check now targets the ARM64 XInput DLL under the lowercase arm64 directory instead of ARM64.
  • observed — Modified behavior in .github/workflows/build.yml: The XInput signing file list now uses the lowercase arm64 directory instead of ARM64.
  • observed — Modified behavior in .github/workflows/build.yml: The signed-XInput verification now checks the lowercase arm64 path instead of ARM64.
Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Publish unsigned ControlApp and XInput builds" matches the main change. The workflow adds an unsigned-tools job that collects ControlApp.exe and the x64, ARM64, and x86 XInput DLLs, checks …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Publish unsigned ControlApp and XInput builds" matches the main change. The workflow adds an unsigned-tools job that collects ControlApp.exe and the x64, ARM64, and x86 XInput DLLs, checks that they are unsigned, and uploads them as control-app-unsigned. The title is short, specific, and free of noise. The objectives describe the same goal.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks each tool in line,
Then packs the unsigned files just fine.
The signed tools follow on their way,
With lowercase paths bright as day.
I thump my paws and cheer the flow!

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3ad254de-fcda-4328-a062-c2e1d7668162
Commits

Reviewing files that changed from the base of the PR and between ccb8143 and 8cf2647.

Files selected for processing: 1

  • .github/workflows/build.yml

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

@nefarius
nefarius merged commit 6ed7ccf into master Nov 8, 2026
9 checks passed
@nefarius
nefarius deleted the ci/publish-unsigned-tools branch November 8, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant