Repository navigation
fix(client): load the review before the websocket opens - #419
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Firefox, a new diffle tab could hang on "Loading snapshot…" for 10 to 50 seconds. Firefox lets only one WebSocket to a host connect at a time. When another tab's socket hangs, for example an old diffle tab reconnecting to a frozen server on another port, Firefox holds the new tab's socket back until its 20 s connect timeout. The client only booted once its socket opened, so the review waited too.
connectWscloses an attempt that has not opened and retries with the usual backoff. A diffle tab no longer blocks other tabs' sockets, or other localhost apps, for 20 s per retry.🧭 lspused to say "no language server for this diff" because it printed before the servers started.LspPool::tracknow starts them before it returns and only syncs documents in the background.Closes #418