Repository navigation
docs(client): point on_*_list_changed callbacks to Peer::listen - #1402
Open
paolocostanzo wants to merge 1 commit into
Open
paolocostanzo wants to merge 1 commit into
paolocostanzo wants to merge 1 commit into
Conversation
Closes modelcontextprotocol#1394 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
@gocamille is on triage rotation this week and is the reviewer for this one. Labels come from the PR labeler. Please review the change. Automated triage. Labels are a first pass and the assigned maintainer has the final say. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1394.
Adds rustdoc to
ClientHandler::on_tool_list_changed,on_prompt_list_changedandon_resource_list_changed.On a connection that negotiates
2026-07-28, list-changed notifications are sent on asubscriptions/listenstream that requested them, and the serve loop routes notifications whoseio.modelcontextprotocol/subscriptionIdmatches an active subscription to thatSubscriptioninstead ofhandle_notification.Peer::listenalready documents this, but the callbacks don't, so a client that only implements them can miss list changes from servers that follow the spec (e.g. aaif-goose/goose#13055).The new docs point to
Peer::listen,SubscriptionFilterBuilder::{tools,prompts,resources}_list_changedand thesubscriptions_streamhttpclient example, and note that the callbacks still receive notifications without a matching subscription (earlier protocol versions, or servers that send them unscoped) and that the list caches are invalidated on both paths.Docs only, no behaviour change.
AI Disclosure (pursuant to the AI Contribution Policy): I used Claude to help write the doc comments and this description (hence the Co-Authored-By trailer); all checks and reviews were handled by me personally, and I take responsibility for the change.