Repository navigation
feat(discord): log in to Discord over OAuth on Full builds and keep kizzy for FOSS - #2809
Merged
Merged
Conversation
…ot downloaded right away
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Full builds now show Discord Rich Presence under SimpMusic's own Discord application, signed in through Discord's OAuth flow instead of kizzy's token login. The new module
core/service/discordasks foropenid sdk.social_layer_presence, the minimum scope Discord documents for Rich Presence, and sets the activity over the gateway with the Bearer token. Discord's consent screen lists the whole presence bundle (friends, invites); the app only connects to the gateway, updates the activity and registers artwork throughexternal-assets. FOSS builds keep kizzy unchanged.The application id stays out of the source: it is read from
DISCORD_CLIENT_IDinlocal.propertiesthrough BuildKonfig, and every Full CI job writes it from the repository secret of the same name.The submodule points at
feature/discord-oauthin maxrave-dev/core, which is not inmultiplatformyet. The branch also carries 53cb9cc (core bump for removed and cancelled downloads going back to not downloaded), which had not reacheddevyet.Linked issue
None.
Checklist