Repository navigation
Enable ModuleDisplay on CoreP4X - #440
Merged
Merged
Conversation
Add CoreP4X to the ESP32-P4 boards that set up ModuleDisplay in M5.begin(), and pass the board M5Unified adopted (detected, fixed or fallback) to M5ModuleDisplay::config_t::board unless the user set it. M5GFX selects the wiring and the write-only transmitter path from that board.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables ModuleDisplay on CoreP4X in
M5.begin().board_M5CoreP4Xto the ESP32-P4 boards that set up ModuleDisplay.M5ModuleDisplay::config_t::boardunless the user set it. M5GFX selects the wiring and the write-only transmitter path from that board.Requires m5stack/M5GFX#407 (adds
config_t::boardand the write-only transmitter path). The ModuleDisplay block is only compiled whenM5ModuleDisplay.his included, so the CI examples build without it; the combination was verified with the full build matrix locally.Verified
M5.begin()adds the display; output from a cold start, from a reset, and after sleep/wakeup. Without the moduleM5.begin()returns with one display.