Repository navigation
DM-56927: Update DP2 color image NB tutorial - #243
Merged
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ameisner
approved these changes
Nov 3, 2026
ameisner
left a comment
ameisner
left a comment
Collaborator
There was a problem hiding this comment.
I ran this updated version as-is and also using the ECDFS field's central coordinates, and it succeeded without any errors in both cases.
I have one minor comment, which is that in Section 1.2 the notebook says:
"Create an instance of the butler, and assert that it exists."
But I don't see an "assert" in the code cell that follows. This could be addressed by either removing the second clause of the above sentence or adding the assert. Since this is a very minor comment, I'm going to approve now.
MelissaGraham
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.