Skip to content

fix(workers): parse JSON before evaluating module graphs - #2750

Open
ldm0 wants to merge 1 commit into
mainfrom
split/solid-worker-module-response-order-20261112
Open

ldm0 wants to merge 1 commit into
mainfrom
split/solid-worker-module-response-order-20261112

Conversation

@ldm0

@ldm0 ldm0 commented Nov 12, 2026

Copy link
Copy Markdown
Member

Parse worker JSON module sources while creating graph records, before any sibling module executes. Retain the parsed default export and cache native compile exceptions across concurrent and repeated imports.

Covers both sibling import orders with unordered HTTP request collection, no sibling execution, exact cached SyntaxError identity, no author JSON.parse/stack hooks, and preserved Text-module behavior. Ports the worker half of 38acf77 with the fixture ordering improvements from 80e9b58. Updates the local static-invalid-JSON smoke fixture to assert the existing intrinsic bootstrap Event contract, because JSON parsing now fails during graph creation rather than evaluation (fixture adaptation from 9972c60). Aligns the existing Wasm source/evaluation concurrency control with native JavaScript SyntaxError propagation, as in the source commit; network failures remain TypeErrors.

Ported from development commit 38acf77a9d9.

Validation on 7d833a973118690c2fcaf0541b7aa0d8979c42e4:

  • cargo fmt --all
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo nextest run --no-fail-fast — Summary [ 209.822s] 22908 tests run: 22908 passed (1 slow), 20 skipped; zero retries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant